Refactor fabric imports #1110
Merged
Refactor fabric imports #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandenburger
added
cleanup
mbrandenburger
force-pushed
the
refactor-fabric-imports
branch
11 times, most recently
from
a5e4044 to
41464a2
Compare
This commit moves the utility functions imported from fabric into the local package, including tests. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
mbrandenburger
force-pushed
the
refactor-fabric-imports
branch
3 times, most recently
from
2952587 to
6cce9ea
Compare
Contributor
|
Great effort, @mbrandenburger . Very useful. One suggestion: Could we move Thanks. |
This commit bundles the dependency on prototuils imported from fabric in a single package. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
This commit moves the discovery client imported from fabric into a local package, including tests. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
This commit moves the rwsetutils imported from fabric into a local package, including tests. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
This commit adds UnmarshalConfigEnvelope to our local protoutils Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
This commit moves common/channelconfig imported from fabric into a local package, including tests. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
mbrandenburger
force-pushed
the
refactor-fabric-imports
branch
2 times, most recently
from
5091465 to
d841d6e
Compare
Member
Author
@adecaro good idea - I moved the packages as you suggested. |
This commit moves msp imported from fabric into a local package, including tests. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
This commit moves protoutils imported from fabric into a local package, including tests. Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
mbrandenburger
force-pushed
the
refactor-fabric-imports
branch
from
d841d6e to
359e531
Compare
AkramBitar
reviewed
Jan 19, 2026
Contributor
AkramBitar
left a comment
AkramBitar
left a comment
There was a problem hiding this comment.
So far so good :-)
LGTM
SaidAltury-ibm
approved these changes
Jan 19, 2026
Contributor
SaidAltury-ibm
left a comment
SaidAltury-ibm
left a comment
There was a problem hiding this comment.
Great effort @mbrandenburger! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces FSC’s dependency on
github.com/hyperledger/fabricby refactoring and moving the required Fabric code intoplatform/fabric. Fabric is not designed or versioned as a reusable Go library, and depending on its internal packages introduces instability, misleading dependency alerts, and maintenance challenges.By internalizing the required functionality, FSC gains fine-grained control over the code it depends on, at the cost of needing to explicitly track and maintain compatibility with Fabric protocol changes. This is a deliberate trade-off.
Additionally, removing direct Fabric dependencies eliminates false-positive Dependabot alerts caused by Fabric’s non-semantic Go module versioning, which incorrectly associates current Fabric releases with older versions such as 1.4 or 2.2.
TODOs: