Skip to content

integration: enable TLS for the fabric-x committer test container#1308

Closed
malsomesh9 wants to merge 1 commit into
hyperledger-labs:mainfrom
malsomesh9:somesh/issue-1295-fabricx-committer-tls
Closed

integration: enable TLS for the fabric-x committer test container#1308
malsomesh9 wants to merge 1 commit into
hyperledger-labs:mainfrom
malsomesh9:somesh/issue-1295-fabricx-committer-tls

Conversation

@malsomesh9

Copy link
Copy Markdown
Contributor

Summary

  • enable Fabric-x TLS in the committer all-in-one test container without forcing mTLS across internal committer services
  • mount the generated orderer TLS material into the container and use TLS-aware readiness, query, notification, and namespace config paths
  • stop relying on fxconfig --wait in the NWO wrapper and use the existing namespace polling to observe commit completion

Testing

  • go test ./integration/nwo/fabric ./integration/nwo/fabricx/...
  • manual committer-container repro using the generated Fabric-x test artifacts to verify TLS health checks and orderer submit path

Fixes #1295
Supersedes #1298

Signed-off-by: Somesh Mal <malsomesh9@gmail.com>
@mbrandenburger

Copy link
Copy Markdown
Member

May I ask why this PR supercedes #1298?

@malsomesh9

Copy link
Copy Markdown
Contributor Author

TLS was still being disabled in the FabricX topology, so the change was not exercising the full TLS path.
the committer container still appeared not to start correctly, suggesting the TLS wiring inside the container was incomplete.
#1308 replaces that approach by:

enabling the test path without relying on the old TLS-disabled topology behavior,
mounting and wiring the generated orderer TLS material into the committer container,
making readiness/query/notification/namespace config paths TLS-aware,
and removing the fxconfig --wait dependency in favor of the existing namespace polling flow.
So the intent behind “supersedes” is: same underlying issue, but #1308 is the more complete and merge-ready version of the fix, rather than an unrelated PR.

@mbrandenburger

mbrandenburger commented Apr 29, 2026

Copy link
Copy Markdown
Member

Thank you @malsomesh9

Closing this PR as the work of #1295
is assigned to @Rozerxshashank and currently WIP in #1298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fabric-x: enable TLS for committer-all-in-one test container

2 participants