fabric: apply ordering TLS defaults to configured orderers (#1112) - #1336
Open
malsomesh9 wants to merge 1 commit into
Open
fabric: apply ordering TLS defaults to configured orderers (#1112)#1336malsomesh9 wants to merge 1 commit into
malsomesh9 wants to merge 1 commit into
Conversation
Signed-off-by: Somesh Mal <malsomesh9@gmail.com>
malsomesh9
marked this pull request as ready for review
April 26, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ordering.tlsEnabledto configured Fabricorderers:entries instead of only discovered channel orderersordering.tlsClientAuthRequiredto configuredorderers:entries as the default client-auth settingtlsEnabled,tlsDisabled, andtlsClientSideAuthopt-insWhy
Issue
#1112is aligning FSC TLS behavior with the documented configuration model. Before this change, theorderingTLS overrides were only used when deriving orderer connections from channel config, while statically configuredfabric.<network>.ordererssilently ignored them.Impact
Configured orderers now follow the same TLS defaulting rules documented for the ordering service. Users can disable or enable TLS for ordering separately from peer traffic, and can enable ordering mTLS centrally without repeating the setting on every configured orderer.
Validation
go test ./platform/fabric/core/generic/config/... ./platform/fabric/core/generic/membership/...