feat(storage): copy query builder into fabric vault driver and redirect imports - #1478
Draft
sid200727 wants to merge 4 commits into
Draft
feat(storage): copy query builder into fabric vault driver and redirect imports#1478sid200727 wants to merge 4 commits into
sid200727 wants to merge 4 commits into
Conversation
|
Hey @sid200727 👋 thanks for the PR! This comment updates automatically as you push changes -- think of it as your PR's live scoreboard! PR Checks✅ DCO Sign-off -- All commits have valid sign-offs. Nice work! ✅ GPG Signature -- All commits have verified GPG signatures. Locked and loaded! ✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing! ✅ Issue Link -- Linked to #1479 (assigned to you). 🎉 All checks passed! Your PR is ready for review. Great job! |
github-actions
Bot
added
the
status: needs revision
sid200727
force-pushed
the
feat/copy-query-builder-to-fabric-vault
branch
2 times, most recently
from
May 23, 2026 22:15
a5c429f to
b62445c
Compare
github-actions
Bot
added
status: needs review
…direct imports - Copy query builder package from platform/view into platform/fabric/services/db/driver/sql/query - Redirect vault.go imports to use the copied query builder with squirrel PlaceholderFormat - Use view pagination package in vault.go to match existing test types - Fix formatting, lint, and SPDX license issues Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
sid200727
force-pushed
the
feat/copy-query-builder-to-fabric-vault
branch
from
June 4, 2026 19:42
fcf42f6 to
22ca596
Compare
sid200727
marked this pull request as draft
June 10, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1479
Part of the query builder migration (2 of 3 PRs).
Following the same approach as fabric-token-sdk PR #1734, this PR copies the SQL query builder from platform/view/services/storage/driver/sql/query/ into platform/fabric/services/db/driver/sql/query/ for the fabric vault driver.
Changes:
-> Copied query builder (common, cond, select, insert, update, delete, pagination) into fabric vault driver
-> Redirected vault.go imports to use the local copy
-> Added test interpreters for each subpackage
-> Full build passes, all tests pass
Next PR: Remove the query builder from platform/view/services/storage/driver/sql/query/ entirely once this is merged.