feat(nwo): add CCaaS support - #1642
Conversation
mbrandenburger
added
NWO
- update existing chaincodes with CCaaS-capable entrypoint - add lifecycle package builder - add CCaaS image/deploy/extension fields and setters - add chaincode extension hook and default image check - add chaincode container manager - add ChaincodeDeployer seam with ccaas default and legacy - wire ccaas external builder and make ccenv image conditional - add CCaaS Dockerfiles and chaincode-images target - build chaincode images before CCaaS integration tests - propagate chaincode Extension through UpdateChaincode Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
1f46507 to
d73e75e
Compare
SaidAltury-ibm
left a comment
SaidAltury-ibm
left a comment
There was a problem hiding this comment.
Thank you @mbrandenburger this looks good i only have one concern about the image map, WYT?
| func ImageForPath(p string) string { | ||
| return pathToImage[p] | ||
| } |
There was a problem hiding this comment.
i was thinking what if p is not in the map? it returns "" and UpdateChaincode take whatever this returns and assigns it directly to the new chaincode Image field with no check. WYT?
|
👋 Hey @mbrandenburger! This PR has been inactive for 5 days. Are you still working on this? We will close this in 2 days if we see no further activity. If you're still on it, leave a comment to let us know! If you'd like to step down, comment |
github-actions
Bot
added
the
status: ready for dev
|
⏱️ This PR has been closed due to 7 days of inactivity. It has been unassigned and reset to If you'd like to continue working on this, feel free to comment |
2 participants
This PR brings back CCaaS support for the Fabric platform in NWO and uses it as the new default.
Closes #1643