Skip to content

fix(test): platform/fabric/core/generic/ordering - #1656

Merged
mbrandenburger merged 1 commit into
hyperledger-labs:mainfrom
mbrandenburger:flaky-osclient-test
Aug 18, 2026
Merged

fix(test): platform/fabric/core/generic/ordering#1656
mbrandenburger merged 1 commit into
hyperledger-labs:mainfrom
mbrandenburger:flaky-osclient-test

Conversation

@mbrandenburger

@mbrandenburger mbrandenburger commented Aug 18, 2026

Copy link
Copy Markdown
Member

This PR addresses the issue reported in #1655. It contains two changes to fix a flaky test in the orderer client.

We now set the time to measure the callerDeadline correctly. Additionally we use defer to correctly close sessions in order to avoid hanging go routines in the test.

Closes #1655

@mbrandenburger mbrandenburger added this to the 26Q3 milestone Aug 18, 2026
@mbrandenburger mbrandenburger self-assigned this Aug 18, 2026
@mbrandenburger mbrandenburger added bug Something isn't working testing All related to testing labels Aug 18, 2026
@github-actions

github-actions Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Hey @mbrandenburger 👋 thanks for the PR!
I'm your friendly PR Helper Bot 🤖 and I'll be riding shotgun on this one, keeping track of your PR's status to help you get it approved and merged.

This comment updates automatically as you push changes -- think of it as your PR's live scoreboard!
Here's the latest:

PR Checks

✅ DCO Sign-off -- All commits have valid sign-offs. Nice work!

❌ GPG Signature -- Heads up! The following commits don't have a verified GPG signature:

  • 2fe461e fix(test): platform/fabric/core/generic/ordering

You'll need to sign your commits with GPG (e.g. git commit -S). See the Signing Guide for a step-by-step walkthrough.

✅ Merge Conflicts -- No merge conflicts detected. Smooth sailing!

✅ Issue Link -- Linked to #1655 (assigned to you).

⏳ All checks must pass before this PR can be reviewed. You've got this!

@github-actions github-actions Bot added the status: needs review The pull request is ready for maintainer review label Aug 18, 2026
@mergify

mergify Bot commented Aug 18, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@mbrandenburger
mbrandenburger enabled auto-merge (squash) August 18, 2026 12:20
@mbrandenburger
fix(test): platform/fabric/core/generic/ordering
2fe461e 
This commit contains two changes to fix a flaky test in the orderer client.
We now set the time to measure the callerDeadline correctly.
Additionally we use defer to correctly close sessions in order to avoid
hanging go routines in the test.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
@mbrandenburger
mbrandenburger merged commit 89e19bc into hyperledger-labs:main Aug 18, 2026
9 of 10 checks passed
@mbrandenburger
mbrandenburger deleted the flaky-osclient-test branch August 18, 2026 12:20
@github-actions github-actions Bot added status: needs revision The pull request requires changes from the author before it can be reviewed or merged and removed status: needs review The pull request is ready for maintainer review labels Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaidAltury-ibm SaidAltury-ibm SaidAltury-ibm approved these changes

Assignees

@mbrandenburger mbrandenburger

Labels

bug Something isn't working status: needs revision The pull request requires changes from the author before it can be reviewed or merged testing All related to testing

Projects

None yet

Milestone

26Q3

Development

Successfully merging this pull request may close these issues.

Flaky test: platform/fabric/core/generic/ordering/client_test.go

2 participants

@mbrandenburger @SaidAltury-ibm