Moved service registration in final SDK from base SDKs #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandrosfilios
force-pushed
the
f-view-factories
branch
4 times, most recently
from
dee6a7e to
1ba5fc1
Compare
Signed-off-by: Alexandros Filios <[email protected]>
alexandrosfilios
force-pushed
the
f-view-factories
branch
from
5e4f74c to
d0a8ec0
Compare
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
Signed-off-by: Alexandros Filios <[email protected]>
adecaro
approved these changes
Mar 26, 2025
| @@ -23,6 +23,9 @@ var ( | |||
| logger = logging.MustGetLogger("fabric-sdk") | |||
| ) | |||
|
|
|||
| const DefaultNetwork = "" | |||
There was a problem hiding this comment.
please, add as single block of constants and give a description of the them
| @@ -36,10 +36,10 @@ func Wrap(tx *endorser.Transaction) (*Transaction, error) { | |||
|
|
|||
| // NewTransaction returns a new instance of a state-based transaction that embeds a single namespace. | |||
| func NewTransaction(context view.Context) (*Transaction, error) { | |||
| return newTransaction(utils.MustGet(fabric.GetNetworkServiceProvider(context)), context) | |||
| return NewTransactionWithFNSP(utils.MustGet(fabric.GetNetworkServiceProvider(context)), context) | |||
There was a problem hiding this comment.
please, don't panic here, check what's the output of fabric.GetNetworkServiceProvider and return an error.
| @@ -211,6 +216,9 @@ func ExchangeRecipientIdentities(context view.Context, recipient view.Identity, | |||
| Network: opt.Network, | |||
| Other: recipient, | |||
| IdentityLabel: opt.Identity, | |||
|
|
|||
| fnsProvider: utils.MustGet(fabric.GetNetworkServiceProvider(context)), | |||
There was a problem hiding this comment.
plase, don't panic, check the output of fabric.GetNetworkServiceProvider.
| finality: o.finality, | ||
| timeout: o.timeout, | ||
| fnsProvider: utils.MustGet(fabric.GetNetworkServiceProvider(ctx)), | ||
| finalityView: NewFinalityViewFactory(utils.MustGet(fabric.GetNetworkServiceProvider(ctx))), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables us to write application without the need for the Service Provider. To this end: