Skip to content

refactor: Cleanup protobuf #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbrandenburger merged 1 commit into from
Oct 27, 2025
Merged

refactor: Cleanup protobuf #937

mbrandenburger merged 1 commit into from
Oct 27, 2025
+942 −1,072

Conversation

@alexandrosfilios
Copy link
Contributor

@alexandrosfilios alexandrosfilios commented May 29, 2025 •
edited by mbrandenburger
Loading

Updated:

This PR addresses #773

  • update protobuf deps
  • add make target to generate all protos
  • re-generate all protos with protov2
  • add protov1 adapter for idemix protos

@alexandrosfilios alexandrosfilios linked an issue May 29, 2025 that may be closed by this pull request
Update protobufs #849
Closed
mbrandenburger
mbrandenburger reviewed May 29, 2025
View reviewed changes
@adecaro
Copy link
Contributor

adecaro commented Jul 17, 2025

@alexandrosfilios , what's the status of this?

@mbrandenburger mbrandenburger changed the title Remove protobuf Cleanup protobuf Oct 27, 2025
@mbrandenburger mbrandenburger self-assigned this Oct 27, 2025
@mbrandenburger mbrandenburger added cleanup Something needs some cleanup dependencies Pull requests that update a dependency file labels Oct 27, 2025
@mbrandenburger mbrandenburger added this to the Q4 milestone Oct 27, 2025
@mbrandenburger mbrandenburger marked this pull request as ready for review October 27, 2025 09:26
@mbrandenburger mbrandenburger requested a review from arner October 27, 2025 09:26
@mbrandenburger mbrandenburger changed the title Cleanup protobuf refactor: Cleanup protobuf Oct 27, 2025
@mbrandenburger mbrandenburger self-requested a review October 27, 2025 13:30
@alexandrosfilios @mbrandenburger
Cleanup protobuf
3fe45b2 
- update protobuf deps
- add make target to generate all protos
- re-generate all protos with protov2
- add protov1 adapter for idemix protos

Signed-off-by: Alexandros Filios <alexandros.filios@ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Copilot AI review requested due to automatic review settings October 27, 2025 15:32
Copilot AI reviewed Oct 27, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

arner
arner approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@arner arner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It looks like this does not impact any persisted data?

@mbrandenburger mbrandenburger merged commit 8bc0feb into main Oct 27, 2025
20 checks passed
@mbrandenburger mbrandenburger deleted the remove-protobuf branch October 27, 2025 17:27
@mbrandenburger mbrandenburger mentioned this pull request Oct 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@arner arner arner approved these changes

@adecaro adecaro Awaiting requested review from adecaro

@mbrandenburger mbrandenburger Awaiting requested review from mbrandenburger

Assignees

@mbrandenburger mbrandenburger

Labels

cleanup Something needs some cleanup dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

25Q4

Development

Successfully merging this pull request may close these issues.

Update protobufs

5 participants

@alexandrosfilios @adecaro @mbrandenburger @arner