Issue915 clean #1028
Open
Issue915 clean #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SREENIDHI DR <[email protected]>
Signed-off-by: SREENIDHI DR <[email protected]>
Signed-off-by: sreenidhi <[email protected]>
Signed-off-by: sreenidhi <[email protected]>
Signed-off-by: sreenidhi <[email protected]>
token/services/ttx/auditor.go
Outdated
| if err != nil { | ||
| span.RecordError(err) | ||
| return nil, errors.WithMessage(err, "failed to read audit event") | ||
| } | ||
| if len(signature) == 0 { |
There was a problem hiding this comment.
is this check needed? it might be misleading as to what is expected from the code if this can't happen. normally I expect that if err == nil, there data is valid.
|
|
||
| msg, err := ReadMessage(context.Session(), time.Minute*4) | ||
| jsonSession := session2.JSON(context) | ||
| msg, err := jsonSession.ReceiveRawWithTimeout(time.Minute * 4) |
There was a problem hiding this comment.
we could also extract these durations to constants, depending on what we are waiting for, e.g. signatureRcvTimeout, txRcvTimeout, to make sure we are aligned and to have a better overview. ideally I would even add them as fields in the structure objects and set the default values in the constructors.
Signed-off-by: sreenidhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.