Skip to content

check owner to identify redeemed tokens #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

check owner to identify redeemed tokens #1039

merged 3 commits into from
Apr 17, 2025

Conversation

adecaro
Copy link
Contributor

@adecaro adecaro commented Apr 16, 2025

This PR fixes the parsing the token request's inputs and outputs. Namely: We clearly identify when an output is redeemed and we don't include it in the list of tokens to be created in the db. We return an error in case of a failure of any sort.

adecaro added 2 commits April 16, 2025 06:15
Signed-off-by: Angelo De Caro <[email protected]>
@adecaro adecaro self-assigned this Apr 16, 2025
@adecaro adecaro added the bug Something isn't working label Apr 16, 2025
Copy link
Contributor

@alexandrosfilios alexandrosfilios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment

@@ -60,8 +60,8 @@ var (

AllTestTypes = []*InfrastructureType{
WebSocketNoReplication,
LibP2PNoReplication,
WebSocketWithReplication,
// LibP2PNoReplication,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to reactivate

@adecaro adecaro merged commit c13a23d into main Apr 17, 2025
54 checks passed
@adecaro adecaro deleted the f-1038 branch April 17, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants