Cleanup external wallets in case some error occurs #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkramBitar
force-pushed
the
fix/external-wallet-cleanup
branch
from
adf3ca8 to
2f2a158
Compare
Use defer to guarantee that Done() is called on all external wallet signers regardless of whether errors occur during signature collection, auditing, or approval phases. This prevents resource leaks when the endorsement process fails early. Previously, if requestSignaturesOnIssues or requestSignaturesOnTransfers returned an error, any external wallets already added to the map would not have their Done() method called, potentially leaving resources uncleaned. Signed-off-by: AkramBitar <akram@il.ibm.com>
AkramBitar
force-pushed
the
fix/external-wallet-cleanup
branch
from
bffa8ba to
3e665a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes resource leak in
CollectEndorsementsViewby ensuringDone()is called on all external wallet signers even when errors occur during signature collection.Changes
Call()methodCleanupExternalWallets()methodSee #1228