Skip to content

Add benchmarks for Quantity operations#1477

Open
theycallmeaabie wants to merge 1 commit intohyperledger-labs:mainfrom
theycallmeaabie:feat/quantity-benchmarks
Open

Add benchmarks for Quantity operations#1477
theycallmeaabie wants to merge 1 commit intohyperledger-labs:mainfrom
theycallmeaabie:feat/quantity-benchmarks

Conversation

@theycallmeaabie
Copy link
Copy Markdown
Contributor

Summary

  • Add benchmarks for BigQuantity and UInt64Quantity operations (Add, Sub, Cmp)
  • Add benchmark for ToQuantity parsing

Resolves #1467

Copilot AI review requested due to automatic review settings April 5, 2026 09:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Go benchmarks to track performance of Quantity implementations and parsing over time (per #1467).

Changes:

  • Adds benchmarks for BigQuantity operations: Add, Sub, Cmp
  • Adds benchmarks for UInt64Quantity operations: Add, Sub, Cmp
  • Adds a benchmark for ToQuantity parsing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adecaro
Copy link
Copy Markdown
Contributor

adecaro commented Apr 10, 2026

Hi @theycallmeaabie , please, resolve the conflicts 🙏

@adecaro adecaro requested review from adecaro April 10, 2026 08:04
@adecaro adecaro self-assigned this Apr 10, 2026
@adecaro adecaro modified the milestone: Q2/26 Apr 10, 2026
Signed-off-by: theycallmeaabie <theycallmeaabie@gmail.com>
@theycallmeaabie theycallmeaabie force-pushed the feat/quantity-benchmarks branch from 60657fb to f51e47b Compare April 10, 2026 08:34
@theycallmeaabie
Copy link
Copy Markdown
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(token/token/quantity.go): improvements

3 participants