fix: cachedFetcher.update() no longer blocks token reads during DB refresh#1535
Open
NETIZEN-11 wants to merge 1 commit intohyperledger-labs:mainfrom
Open
fix: cachedFetcher.update() no longer blocks token reads during DB refresh#1535NETIZEN-11 wants to merge 1 commit intohyperledger-labs:mainfrom
NETIZEN-11 wants to merge 1 commit intohyperledger-labs:mainfrom
Conversation
Signed-off-by: Nitesh <nitesh@example.com>
c05df30 to
3b791af
Compare
Author
|
@adecaro Would love a review on this. Thanks! |
Contributor
|
Hi @NETIZEN-11 , thanks for submitting this 🙏 Thanks much 🙏 |
Contributor
|
@NETIZEN-11 , please, run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was fixed
The
cachedFetcher.update()function intoken/services/selector/sherdlock/fetcher.gowas holding a write lock for the entire duration of the database query. This meant whenever the cache needed to refresh (e.g., on a slow DB), all token read operations would block waiting for the lock.How it was fixed
Tests added
TestCachedFetcher_UpdateDoesNotBlockReaders: verifies that concurrent readers can still acquire the lock while update() is waiting on the databaseTestCachedFetcher_UpdateReacquiresLockAfterDB: verifies the cache is correctly updated after the lock is re-acquired