Skip to content

Add appendix on externally verirfiable transaction properties #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

r3domfox
Copy link
Contributor

@r3domfox r3domfox commented Jul 5, 2023

Following discussion with Adhara about the need to verify a specific property of the Corda transaction in the Adhara cross-chain swap protocol, an appendix explains how this works, what the drawbacks of the approach are, and how a future improvement might address it.

@r3domfox r3domfox requested a review from a team as a code owner July 5, 2023 15:27
@gendal
Copy link
Contributor

gendal commented Jul 6, 2023

Looks good - thanks Dom.

My main comment would be perhaps to move the 'motivation' pieces higher up. Or insert something like the following immediately before the paragraph that introduces the 'externally verifiable transaction property' concept?

(immediately after the para explaining how expensive/difficult it is to parse Corda transactions)

"However, it turns out that the relative opacity of serialised Corda transactions is not a major issue in practice. This is because the reason a Solidity contract needs to inspect a Corda transaction is usually to ensure that it is associated with the same 'business transaction' (eg a trade in the real world) that the solidity contract is managing. In some cases, the the Corda Transaction ID can be securely furnished to the Solidity contract, which then merely needs to satisfy itself that the Transaction has been signed and notarised by the expected parties. In other cases, the Solidity contract may not know or care what the Corda Transaction ID is; it just needs to know that all the parties to a Corda Transaction associated with the overarching business transaction (eg trade) signed and notarised it. Is is this second scenario we are concerned with here"

@gendal
Copy link
Contributor

gendal commented Jul 6, 2023

cc @petermunnings - would also be good to get your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants