Pull out the guardian into a separate, reusable package #83
+127
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guardian service is a component used by several contract packages. This pulls out an operation independent version that can be used across all of the contract families. Each family need only define the operations specific to their contract requirements. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extracts the guardian service into a dedicated, reusable package to be shared across contract families.
- Consolidates guardian-related operations into a separate module and updates related import paths.
- Updates package dependencies in setup.py and adjusts configuration in the service’s TOML file.
- Introduces new guardian common modules and updates wsgi endpoint references.
Reviewed Changes
Copilot reviewed 26 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| inference-contract/etc/guardian_service.toml | Added Operations setting (note module path may need review) |
| common-contract/setup.py | Updated dependencies and added pdo-sservice dependency |
| common-contract/pdo/contracts/guardian/wsgi/*.py | Refactored imports from pdo.inference to pdo.contracts.guardian |
| common-contract/pdo/contracts/guardian/common/*.py | Added new common modules for the guardian package |
| common-contract/pdo/contracts/init.py | Updated all to include guardian components |
Files not reviewed (2)
- common-contract/MANIFEST: Language not supported
- inference-contract/MANIFEST: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guardian service is a component used by several contract packages. This pulls out an operation independent version that can be used across all of the contract families. Each family need only define the operations specific to their contract requirements.