Move the remaining guardian service functionality into the common contract package #86
+162
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tract package Move the controlling scripts and configuration files out of the inference contract into the common contract family. This should make for a fully reusable package. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the remaining guardian service functionality from the inference contract to the common contract package to enhance reusability. Key changes include:
- Removing the legacy export of the inference guardian from the inference plugins.
- Updating module paths in jupyter.py and tokens.toml to reference the new guardian service location.
- Adding new package configurations and files (resources, scripts, plugins, and configuration files) to support the common guardian service functionality.
Reviewed Changes
Copilot reviewed 18 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| inference-contract/pdo/inference/plugins/init.py | Removed legacy export for inference guardian functionality |
| inference-contract/pdo/inference/jupyter.py | Updated module path to point to the new guardian service location |
| inference-contract/context/tokens.toml | Updated guardian module reference to the common package |
| common-contract/setup.py | Added new packages and an entry point for the guardian service |
| common-contract/pdo/contracts/resources/resources.py | Introduced resource installation functionality |
| common-contract/pdo/contracts/guardian/scripts/init.py | Defined the guardianCLI export |
| common-contract/pdo/contracts/guardian/plugins/guardian_service.py | Refactored command creation and binding for guardian service operations |
| common-contract/pdo/contracts/guardian/plugins/init.py | Exported the guardian_service module |
| common-contract/etc/guardian_service.toml | Added configuration for the guardian service |
Files not reviewed (5)
- common-contract/MANIFEST: Language not supported
- common-contract/MANIFEST.in: Language not supported
- common-contract/scripts/gs_start.sh: Language not supported
- inference-contract/MANIFEST: Language not supported
- inference-contract/MANIFEST.in: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the controlling scripts and configuration files out of the inference contract into the common contract family. This should make for a fully reusable package.