Uninstall notebooks and contracts #89
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uninstall the special artifacts that get installed like the notebooks and contract binaries. Signed-off-by: Mic Bowman <mic.bowman@intel.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an uninstall target to remove installed artifacts from both the Makefile and CMakeLists.txt, addressing cleanup of installation outputs.
- Added an "uninstall" target in the Makefile that echoes a message and tries to run an uninstall command if the build directory exists
- Set up a custom "uninstall" target in CMakeLists.txt to remove files listed in the install manifest
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | New uninstall target using directory check and invoking build uninstall |
| CMakeLists.txt | New custom target and command to remove installed artifacts via install_manifest.txt |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Mic Bowman <cmickeyb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Makefile target to clean artifacts installed outside the python processes