feat(example-portfolio): use standard machinery for transfers #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does a few things:
- It removes our own Transfer type in the portfolio in favor of the one
exposed by TransferInstructionView
- It refactors TransactionHistoryService to use `txparse` in favor of our own
parsing
* This means the type for transfers here also changed to the standard
TransferInstructionView
Signed-off-by: Jasper Van der Jeugt <[email protected]>
jaspervdj-da
force-pushed
the
jaspervdj/portfolio-transfers-prettycontract
branch
from
72471e0 to
f743d21
Compare
mjuchli-da
approved these changes
Dec 22, 2025
Signed-off-by: Jasper Van der Jeugt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
txparsein favor of our own parsing