Open
Conversation
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
jarekr-da
force-pushed
the
jarekr/localnet_multusync
branch
from
3edf937 to
c4c8669
Compare
jarekr-da
changed the title
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
Signed-off-by: jarekr-da <jaroslaw.ratajski@digitalasset.com>
mziolekda
reviewed
Apr 21, 2026
| ) | ||
|
|
||
| // Connect app-provider to the new synchronizer. | ||
| // Note: app-user is intentionally NOT connected to app-synchronizer so that |
Contributor
There was a problem hiding this comment.
Is that something that you intend to rectify? Ultimately, app-user should be connected to both
mziolekda
reviewed
Apr 21, 2026
|
|
||
| for (participant <- Seq(`app-provider`)) { | ||
| val vettedFromAuthorized = participant.topology.vetted_packages | ||
| .list(store = Some(TopologyStoreId.Authorized), filterParticipant = participant.id.filterString) |
Contributor
There was a problem hiding this comment.
This should rather be the global-synchronizer instead of Authorized store
PHOL-DA
approved these changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
can you create and move these into canton/multi-sync instead ? the script folder is specifically for our scriptings and not for bootstrapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems that it just works now!