Fix broken retry logic when synchroniser is disconnected (#1035)

Author: fayi-da

apps/common/frontend/src/contexts/LedgerApiContext.tsx

@@ -10,16 +10,16 @@ import { Choice, ContractId, Template, TemplateOrInterface } from '@daml/types';
 
 const ANS_LEDGER_NAME = 'ans-ledger';
 
+interface JsonApiErrorBody {
+  error: string;
+}
+
 interface JsonApiErrorResponse {
   status: number;
   statusText: string;
   body: JsonApiErrorBody;
 }
 
-interface JsonApiErrorBody {
-  error: string;
-}
-
 export class JsonApiError extends Error {
   status: number;
   statusText: string;

apps/common/frontend/src/utils/helpers.ts

@@ -53,12 +53,13 @@ export const unitToCurrency = (unit: Unit): string => {
   return unitStringToCurrency(unit.toUpperCase());
 };
 
-export const retrySynchronizerError = (failureCount: number, error: Error): boolean => {
-  // We only retry certain JSON API errors. Retrying everything is more confusing than helpful
-  // because that then also retries on invalid user input.
+export const isDomainConnectionError: (error: Error) => boolean = (error: Error) => {
   const errResponse = error as JsonApiError;
   const keywords = ['NOT_CONNECTED_TO_SYNCHRONIZER', 'NOT_CONNECTED_TO_ANY_SYNCHRONIZER'];
-  const isDomainConnectionError = keywords.some(k => errResponse.body?.error?.includes(k));
 
-  return isDomainConnectionError && failureCount < 10;
+  return keywords.some(k => errResponse.body?.error?.includes(k));
+};
+
+export const retrySynchronizerError = (failureCount: number, error: Error): boolean => {
+  return isDomainConnectionError(error) && failureCount < 10;
 };

apps/splitwell/frontend/src/App.tsx

@@ -4,6 +4,7 @@ import {
   AuthProvider,
   UserProvider,
   theme,
+  isDomainConnectionError,
   PackageIdResolver,
   JsonApiError,
 } from '@lfdecentralizedtrust/splice-common-frontend';
@@ -60,11 +61,9 @@ const Providers: React.FC<React.PropsWithChildren> = ({ children }) => {
           // We only retry certain JSON API errors. Retrying everything is more confusing than helpful
           // because that then also retries on invalid user input.
           const errResponse = error as JsonApiError;
-          const keywords = ['NOT_CONNECTED_TO_ANY_DOMAIN', 'NOT_CONNECTED_TO_DOMAIN'];
-          const isDomainConnectionError = keywords.some(k => errResponse.body?.error?.includes(k));
           const is404or409 = [404, 409].includes(errResponse.status);
 
-          return (is404or409 || isDomainConnectionError) && failureCount < 10;
+          return (is404or409 || isDomainConnectionError(error)) && failureCount < 10;
         },
         // Exponential backoff up to a maximum of 30 seconds
         retryDelay: attemptIndex => Math.min(1000 * 1.5 ** attemptIndex, 30000),