Skip to content

Commit 29f3117

Browse files
authored
[static] update TODOs following issue migration (#1004)
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
1 parent dca124e commit 29f3117

File tree

272 files changed

+448
-446
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

272 files changed

+448
-446
lines changed

.envrc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ use_flake_subdir() {
1010
eval "$(nix print-dev-env --profile "$(direnv_layout_dir)/flake-profile" "path:nix" "$@")"
1111
}
1212

13-
# TODO(#3876) work around for $TMPDIR is removed. #3876 to investigate more
13+
# TODO(DACH-NY/canton-network-node#3876) work around for $TMPDIR is removed. #3876 to investigate more
1414
OLD_TMPDIR=$TMPDIR
1515

1616
use flake_subdir
1717

18-
# TODO(#3876) work around for $TMPDIR is removed. #3876 to investigate more
18+
# TODO(DACH-NY/canton-network-node#3876) work around for $TMPDIR is removed. #3876 to investigate more
1919
export TMPDIR=$OLD_TMPDIR
2020

2121
source_env .envrc.vars

.github/actions/nix/run_bash_command_in_nix/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ runs:
7777
7878
. .envrc.vars
7979
80-
# TODO(#17839): once we support cluster deployments in GHA, add cluster authentication here
80+
# TODO(#615): once we support cluster deployments in GHA, add cluster authentication here
8181
8282
MAX_RETRY=${{ inputs.cmd_retry_count }}
8383
n=0
@@ -112,7 +112,7 @@ runs:
112112
}
113113
cmd_wrapper && break
114114
115-
# TODO(#17839): support a conditional retry (cmd_retry_condition argument in CCI), used for retrying if VPN failed
115+
# TODO(#615): support a conditional retry (cmd_retry_condition argument in CCI), used for retrying if VPN failed
116116
117117
n=$[$n+1]
118118
done

.github/actions/scripts/backport_reminder.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ async function main(deps) {
6969

7070
const allBranches = [
7171
...(clusterBranches.map(c => flattenBranchesForCluster(c))),
72-
// TODO(#16006): un-hardcode release-line-0.2 here
72+
// TODO(DACH-NY/canton-network-node#16006): un-hardcode release-line-0.2 here
7373
['main', 'release-line-0.2', 'release-line-0.3.0']
7474
]
7575

.github/actions/scripts/check-logs.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ find_exceptions |
8989

9090
### Look for leaked secrets
9191

92-
# TODO(#14876) Patch secrets in the log file
92+
# TODO(DACH-NY/canton-network-internal#481) Patch secrets in the log file
9393
sed -i 's/secret=test/secret=hidden/g' "$LOGFILE"
9494

9595
find_secrets() {

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ jobs:
129129
runs_on: self-hosted-k8s-large
130130
test_names_file: 'test-full-class-names.log'
131131
start_canton_options: -w
132-
# TODO(#10912) Investigate why things got slower
132+
# TODO(DACH-NY/canton-network-node#10912) Investigate why things got slower
133133
parallelism: 10
134134
test_name: wall-clock-time
135135
with_gcp_creds: true

CANTON_CODE_CHANGES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ to know which and/or what changes we'll need to upstream before the switch.
2727
* ``PositiveFiniteDuration` config reader and writer made public
2828
* `ProofOfOwnership` made public
2929
## Misc
30-
* Added support for interface filters in ledger api ACS commands. TODO (#17403): This should be upstreamed.
30+
* Added support for interface filters in ledger api ACS commands. TODO (#638): This should be upstreamed.
3131
* Generalization of `Environment`
3232
* Generalization of `MetricsFactory`
3333
* Removed a trailing comma in many places because the CC Scala compiler doesn't like it (e.g. `.authorize(op, domain, mediator, side, key.some, )` -> `.authorize(op, domain, mediator, side, key.some)`)

apps/ans/frontend/src/__tests__/setup/config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
22
// SPDX-License-Identifier: Apache-2.0
33

4-
// TODO(#7579) -- remove duplication from default config
4+
// TODO(#986) -- remove duplication from default config
55

66
const config = {
77
auth: {

apps/ans/frontend/src/context/ValidatorScanProxyContext.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
ResponseContext,
1616
} from 'scan-proxy-openapi';
1717

18-
//TODO(#8571) deduplicate this and reuse from specific libraries instead of all on common frontend
18+
//TODO(DACH-NY/canton-network-node#8571) deduplicate this and reuse from specific libraries instead of all on common frontend
1919
const ValidatorScanProxyContext = React.createContext<ScanProxyApi | undefined>(undefined);
2020

2121
export interface ValidatorScanProxyProps {

apps/ans/frontend/src/hooks/queries/usePrimaryParty.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
// Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
22
// SPDX-License-Identifier: Apache-2.0
3-
// TODO(#8515) - reuse this from wallet UI
3+
// TODO(DACH-NY/canton-network-node#8515) - reuse this from wallet UI
44
import { useUserStatus } from './useUserStatus';
55

66
// A hook to fetch the primary party ID via the wallet userStatus API
7-
// TODO(#5176) -- consider querying the json ledger API instead to avoid having more than 1 primary party hook
7+
// TODO(DACH-NY/canton-network-node#5176) -- consider querying the json ledger API instead to avoid having more than 1 primary party hook
88
export const usePrimaryParty = (): string | undefined => {
99
const userStatusQuery = useUserStatus();
1010
return userStatusQuery.data?.partyId;

apps/ans/frontend/src/hooks/queries/useUserStatus.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// Copyright (c) 2024 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved.
22
// SPDX-License-Identifier: Apache-2.0
3-
// TODO(#8515) - reuse this from wallet UI
3+
// TODO(DACH-NY/canton-network-node#8515) - reuse this from wallet UI
44
import { useUserState } from '@lfdecentralizedtrust/splice-common-frontend';
55
import { useQuery, UseQueryResult } from '@tanstack/react-query';
66

0 commit comments

Comments
 (0)