Fix wrong controller in WalletUserProxy_TransferInstruction_Withdraw (#3216)

fixes #3215 [ci]

Signed-off-by: Simon Meier <simon@digitalasset.com>

Author: meiersi-da

daml/dars.lock

@@ -75,7 +75,8 @@ splice-util 0.1.4 b7356fbb2cf8a3b22194d8c743c3c216d9c7527b257c8c38b257eb22942be3
 splice-util-featured-app-proxies 1.0.0 48e0c4fe4ea05e3b740404ebe37004ddd741efbdcd665c1c3199a5d6d9d944d7
 splice-util-featured-app-proxies 1.1.0 81dd5a9e5c02d0de03208522a895fb85eeb12fbea4aca7c4ad0ad106f3b0bfce
 splice-util-featured-app-proxies 1.2.0 653c48879064332d34af5008bdfd8e349493460e67e62b85e8e7e3392831c842
-splice-util-featured-app-proxies-test 1.0.4 ef633c6eff2d786cc571e58f572c5a0c72d31b7ffc1eeeedc420791c50b9a7f1
+splice-util-featured-app-proxies 1.2.1 06bab917848ef275317c2539b75c23b94e03ceb55b4a1346936f7832084cd7a6
+splice-util-featured-app-proxies-test 1.0.5 c743b3ede62dfa5a1587548ae6498b4ace7be6028fb191bbb4ffdbbf1b971d90
 splice-util-token-standard-wallet 1.0.0 1da198cb7968fa478cfa12aba9fdf128a63a8af6ab284ea6be238cf92a3733ac
 splice-util-token-standard-wallet-test 1.0.0 ee328d4744bce339f040078d7271a3d73c932d23589cfa1cfbd99aaf6408c3c2
 splice-validator-lifecycle 0.1.0 cef96fac957362f1fc097120bd13686cac7f84fbc8053afa994a1f9214d9570c

daml/dars/splice-util-featured-app-proxies-1.2.1.dar

@@ -11,7 +11,7 @@ description: |
   are normal .dar files and can be shared by copying the .dars.
   (TODO(#594): remove this limitation)
 source: daml
-version: 1.0.4
+version: 1.0.5
 dependencies:
   - daml-prim
   - daml-stdlib

daml/splice-util-featured-app-proxies-test/daml.yaml

@@ -154,6 +154,81 @@ test_two_step_featured_app_markers = do
   WalletClient.checkBalanceApprox alice registry.instrumentId 990.0
   WalletClient.checkBalance bob registry.instrumentId 10.0
 
+test_transfer_withdraw_and_reject : Script ()
+test_transfer_withdraw_and_reject = do
+  registry <- AmuletRegistry.initialize AmuletRegistry.defaultAmuletRegistryConfig with
+    noTransferFee = True
+
+  -- Setup a wallet provider that will host alice
+  aliceProvider <- setupWalletProvider registry "aliceWalletProvider" None
+  bobProvider <- setupWalletProvider registry "bobWalletProvider" None
+
+  alice <- allocatePartyExact "alice"
+  bob <- allocatePartyExact "bob"
+
+  -- setup alice with 1000 Amulet tokens
+  AmuletRegistry.tapLockedAndUnlockedFunds registry alice 1000.0
+
+  let mkTransferOffer = do
+        aliceHoldings <- WalletClient.listHoldingCids alice registry.instrumentId
+        transfer <- mkImmediateTransfer registry alice bob 20.0 aliceHoldings
+
+        -- alice's wallet frontend also gets the WalletProviderData from the wallet provider's backend
+        -- and creates a transaction that creates featured app activity markers for both alice and the wallet provider
+        _ <- submitWithDisclosures' alice (aliceProvider.extraDisclosuresForProxy <> transfer.disclosures) $ exerciseCmd
+          (aliceProvider.proxyCid)
+          WalletUserProxy_TransferFactory_Transfer with
+            cid = transfer.value.factoryCid
+            proxyArg = ProxyArg with
+              user = alice
+              choiceArg = transfer.value.choiceArg
+              featuredAppRightCid = aliceProvider.featuredAppRightCid
+
+        [(bobInstrCid,_)] <- WalletClient.listTransferOffers bob registry.instrumentId
+        pure bobInstrCid
+
+  -- test withdraw by sender
+  offerCid <- mkTransferOffer
+  context <- RegistryApi.getTransferInstruction_RejectContext registry offerCid emptyMetadata
+
+  -- submit via proxy to create featured app markers
+  result0 <- submitWithDisclosures' alice (aliceProvider.extraDisclosuresForProxy <> context.disclosures) $ exerciseCmd
+    (aliceProvider.proxyCid)
+    WalletUserProxy_TransferInstruction_Withdraw with
+      cid = offerCid
+      proxyArg = ProxyArg with
+        user = alice
+        choiceArg = TransferInstruction_Withdraw with
+          extraArgs = ExtraArgs with
+            context = context.choiceContext
+            meta = emptyMetadata
+        featuredAppRightCid = aliceProvider.featuredAppRightCid
+
+  let result = result0.choiceResult
+  TransferInstructionResult_Failed <- pure result.output
+
+  -- test rejection by receiver
+  offerCid <- mkTransferOffer
+  context <- RegistryApi.getTransferInstruction_RejectContext registry offerCid emptyMetadata
+
+  -- submit via proxy to create featured app markers
+  result0 <- submitWithDisclosures' bob (bobProvider.extraDisclosuresForProxy <> context.disclosures) $ exerciseCmd
+    (bobProvider.proxyCid)
+    WalletUserProxy_TransferInstruction_Reject with
+      cid = offerCid
+      proxyArg = ProxyArg with
+        user = bob
+        choiceArg = TransferInstruction_Reject with
+          extraArgs = ExtraArgs with
+            context = context.choiceContext
+            meta = emptyMetadata
+        featuredAppRightCid = bobProvider.featuredAppRightCid
+
+  let result = result0.choiceResult
+  TransferInstructionResult_Failed <- pure result.output
+
+  pure ()
+
 
 -- Testing batch transfer via wallet proxy
 --------------------------------------------

daml/splice-util-featured-app-proxies-test/daml/Splice/Util/FeaturedApp/IntegrationTests/TestWalletUserProxy.daml

@@ -1,7 +1,7 @@
 sdk-version: 3.3.0-snapshot.20250502.13767.0.v2fc6c7e2
 name: splice-util-featured-app-proxies
 source: daml
-version: 1.2.0
+version: 1.2.1
 dependencies:
   - daml-prim
   - daml-stdlib

daml/splice-util-featured-app-proxies/daml.yaml

@@ -114,7 +114,7 @@ template WalletUserProxy with
       do
         exerciseProxyChoice this cid proxyArg $ \cid -> do
           instr <- fetch cid
-          pure (view instr).transfer.receiver
+          pure (view instr).transfer.sender
 
     nonconsuming choice WalletUserProxy_AllocationFactory_Allocate
       : ProxyResult AllocationInstructionResult

daml/splice-util-featured-app-proxies/daml/Splice/Util/FeaturedApp/WalletUserProxy.daml

@@ -32,6 +32,13 @@ Upcoming
     and are now set to zero to avoid consensus problems when an SV reads aggregates
     from the rest of the network when first joining.
 
+- Daml
+
+  - Fixed a bug in ``WalletUserProxy_TransferInstruction_Withdraw``, where the controller was
+    required to be the ``receiver`` instead of the ``sender`` of the transfer instruction. Upgrade
+    to ``splice-util-featured-app-proxies`` version ``1.2.1`` or newer to get the fix.
+
+
 0.5.1
 -----