Skip to content

Update error type of json api errors #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fayi-da wants to merge 1 commit into from
Closed

Update error type of json api errors #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/common/frontend/src/contexts/LedgerApiContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,14 @@ interface JsonApiErrorResponse {
body: JsonApiErrorBody;
}

interface JsCantonError {
code: string;
cause: string;
correlationId: string;
}

interface JsonApiErrorBody {
error: string;
error: JsCantonError;
}

export class JsonApiError extends Error {
Expand Down Expand Up @@ -169,7 +175,7 @@ export class LedgerApiClient {
console.debug(`${describeChoice} succeeded.`);
return r.json();
} else {
const body = await r.text();
const body = JSON.parse(await r.text());
throw new JsonApiError({
status: r.status,
body: { error: body },
Expand Down
2 changes: 1 addition & 1 deletion apps/common/frontend/src/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const retrySynchronizerError = (failureCount: number, error: Error): bool
// because that then also retries on invalid user input.
const errResponse = error as JsonApiError;
const keywords = ['NOT_CONNECTED_TO_SYNCHRONIZER', 'NOT_CONNECTED_TO_ANY_SYNCHRONIZER'];
const isDomainConnectionError = keywords.some(k => errResponse.body?.error?.includes(k));
const isDomainConnectionError = keywords.some(k => errResponse.body?.error?.code.includes(k));

return isDomainConnectionError && failureCount < 10;
};
Loading