Skip to content

Conversation

@martinflorian-da
Copy link
Contributor

Fixes DACH-NY/cn-test-failures#4467

CI should tell me if I missed anything important.

To prevent adding something I shouldn't be, I compared with other branches on this repo; a bunch of stuff had to be removed by hand.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Fixes DACH-NY/cn-test-failures#4467

CI should tell me if I missed anything important.

To prevent adding something I shouldn't be, I compared with other branches on this repo;
a bunch of stuff had to be removed by hand.

[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
s.a. #1032

[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
Signed-off-by: Martin Florian <martin.florian@digitalasset.com>

[ci]
[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
…his branch

[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
the hassle to get it to work doesn't seem worth it

[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[ci]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
@isegall-da
Copy link
Contributor

/hdm_test

1 similar comment
@isegall-da
Copy link
Contributor

/hdm_test

@isegall-da
Copy link
Contributor

Ah, testing hdm_test from here was wrong.
Running now:
run-job: deploy-hdm-operator
base-splice-git-ref:
upgrade-splice-git-ref:
cluster: scratchneta
link

@isegall-da
Copy link
Contributor

@isegall-da
Copy link
Contributor

Now failing on:

Back-off pulling image "ghcr.io/digital-asset/decentralized-canton-sync-dev/docker/pulumi-kubernetes-operator:v0.3.21-snapshot.20250606.142.0.v20eb2b3b"

Why is it thinking that it's a snapshot? 🤔

@isegall-da
Copy link
Contributor

Why is it thinking that it's a snapshot? 🤔

Ah, because it's a commit on the PR branch, and not on the release line.
Two options: either I push this snapshot, or I merge this and try HDM from the release line. I'll try the former, and keep this as a PR that I can continue iterating on and eventually merge while everybody's out on a long weekend...

@isegall-da
Copy link
Contributor

isegall-da commented Jun 6, 2025

😢
publish-internal-release failed with:
/home/********/project/splice/build-tools/get-release-if-on-release-branch.sh: No such file or directory

Backporting that from main.

@isegall-da
Copy link
Contributor

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
@isegall-da isegall-da force-pushed the martinflorian-da/fix-sync-0.3.21 branch from a99e4fa to 8a831ab Compare June 6, 2025 23:25
@isegall-da
Copy link
Contributor

Woohoo, the HDM test has passed deploying 0.3.21 and triggering migration. Seems enough to merge this!

@isegall-da isegall-da marked this pull request as ready for review June 6, 2025 23:29
@isegall-da isegall-da enabled auto-merge (squash) June 6, 2025 23:30
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
@isegall-da isegall-da disabled auto-merge June 6, 2025 23:53
@isegall-da isegall-da merged commit 0311cd6 into release-line-0.3.21 Jun 6, 2025
31 checks passed
@isegall-da isegall-da deleted the martinflorian-da/fix-sync-0.3.21 branch June 6, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants