-
Notifications
You must be signed in to change notification settings - Fork 59
Simonletort da/1034 from the docs site, users do not know how they can suggest changes to the docs #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
simonletort-da
wants to merge
23
commits into
hyperledger-labs:main
Choose a base branch
from
simonletort-da:simonletort-da/1034-From-the-docs-site,-users-do-not-know-how-they-can-suggest-changes-to-the-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Simonletort da/1034 from the docs site, users do not know how they can suggest changes to the docs #1036
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
9e4e736
How to contribute in FAQ
simonletort-da 741ee26
typo
simonletort-da a23c169
[static]
simonletort-da 26ad32e
link to setup readme from docs readme
simonletort-da 54178b7
fix link
simonletort-da 461dc67
Nix on GH Codespaces
simonletort-da ca0a2b7
Nix via GH Codespaces
simonletort-da 49a6384
Merge branch 'simonletort-da/1034-From-the-docs-site,-users-do-not-kn…
simonletort-da f6b917f
install requirements script, makefile, readme updated
ethancohen-da 2326e76
xcode install
ethancohen-da 1da719e
requirements
ethancohen-da 796c5af
Update .gitignore
ethancohen-da d11a530
remove venv
ethancohen-da deeb4d1
temporary simplifies conf.py
simonletort-da a59bfa4
Add 'Hi ethan' to deployment documentation and improve doc setup files
ethancohen-da 82a47f4
Updated deployment.rst
ethancohen-da dacd35f
Update deployment.rst
simonletort-da d702f06
update deployment.rst
simonletort-da 82dfcd4
[static]
simonletort-da 19a4a1b
Moved deployment.rst file to its own overview section in index and ch…
ethancohen-da 36c2640
Merge branch 'simonletort-da/1034-From-the-docs-site,-users-do-not-kn…
simonletort-da 566fefe
Merge pull request #1 from simonletort-da/731-Document-high-level-rol…
simonletort-da f02033a
modify overview.rst format
simonletort-da File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| { | ||
| "image": "ghcr.io/zombiezen/codespaces-nix" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| src/app_dev/api | ||
| html/ | ||
| html/ | ||
| venv/ | ||
| build/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Makefile for Sphinx documentation | ||
| # | ||
|
|
||
| # You can set these variables from the command line. | ||
| SPHINXOPTS = | ||
| SPHINXBUILD = sphinx-build | ||
| SPHINXAUTOBUILD = sphinx-autobuild | ||
| SOURCEDIR = src | ||
| BUILDDIR = build | ||
|
|
||
| # Put all phony targets here so that file names with the same name as phony targets | ||
| # will not confuse make. | ||
| .PHONY: help html livehtml clean | ||
|
|
||
| # Default target: show help. | ||
| help: | ||
| @echo "Please use \`make <target>' where <target> is one of" | ||
| @echo " html to build the HTML documentation" | ||
| @echo " livehtml to automatically rebuild and preview the site on changes" | ||
| @echo " clean to remove all build files" | ||
|
|
||
| # Build the HTML documentation | ||
| html: | ||
| @echo "Building HTML documentation..." | ||
| $(SPHINXBUILD) -b html $(SOURCEDIR) $(BUILDDIR)/html $(SPHINXOPTS) | ||
| @echo "Build finished. Open $(BUILDDIR)/html/index.html to view." | ||
|
|
||
| # Run the live-reloading server for previewing | ||
| livehtml: | ||
| @echo "Starting live-reloading server..." | ||
| @echo "Your browser should open automatically. Press Ctrl+C to stop." | ||
| $(SPHINXAUTOBUILD) $(SOURCEDIR) $(BUILDDIR)/html $(SPHINXOPTS) | ||
|
|
||
| # Remove all generated build files | ||
| clean: | ||
| @echo "Cleaning build directory..." | ||
| rm -rf $(BUILDDIR)/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -eou pipefail | ||
|
|
||
| root_dir=$(cd "$(dirname $0)"; cd ..; pwd -P) | ||
| input_dir="${root_dir}/docs/src" | ||
| preview_dir="${root_dir}/docs/preview" | ||
| config_dir="${root_dir}/docs/src" | ||
|
|
||
| # Let's remove the dir to be 100% sure there are no stale files | ||
| # The build is relatively small and we can afford it | ||
| rm -Rf $preview_dir | ||
|
|
||
| sphinx-build -M html $input_dir $preview_dir --fresh-env --conf-dir $config_dir --fail-on-warning | ||
|
|
||
| # Make the generated files read-only | ||
| find $preview_dir -type f -follow -exec chmod 0444 {} + | ||
|
|
||
| if [[ $# -gt 0 && "$1" == "--with-preview" ]]; then | ||
| python -m http.server -d ./doc/preview/html | ||
| fi | ||
|
|
||
|
|
||
| ##### | ||
| # install | ||
| ##### | ||
| # brew install pyenv | ||
| # pyenv install 3.10.13 | ||
| # cd /Users/simonletort/Documents/GitHub/splice | ||
| # pyenv local 3.10.13 | ||
| # pyenv virtualenv 3.10.13 splice-docs | ||
| # pyenv local splice-docs | ||
| # pip install sphinx sphinx-autobuild pyyaml | ||
| # which python | ||
| # python --version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Configuration file for the Sphinx documentation builder. | ||
| # | ||
| # For the full list of built-in configuration values, see the documentation: | ||
| # https://www.sphinx-doc.org/en/master/usage/configuration.html | ||
|
|
||
| # -- Project information ----------------------------------------------------- | ||
| # https://www.sphinx-doc.org/en/master/usage/configuration.html#project-information | ||
|
|
||
| project = 'Sphinx' | ||
| copyright = '2025, Ethan Cohen' | ||
| author = 'Ethan Cohen' | ||
|
|
||
| # -- General configuration --------------------------------------------------- | ||
| # https://www.sphinx-doc.org/en/master/usage/configuration.html#general-configuration | ||
|
|
||
| extensions = [] | ||
|
|
||
| templates_path = ['_templates'] | ||
| exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store'] | ||
|
|
||
|
|
||
|
|
||
| # -- Options for HTML output ------------------------------------------------- | ||
| # https://www.sphinx-doc.org/en/master/usage/configuration.html#options-for-html-output | ||
|
|
||
| html_theme = 'alabaster' | ||
| html_static_path = ['_static'] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| .. Sphinx documentation master file, created by | ||
| sphinx-quickstart on Tue Jun 17 14:38:50 2025. | ||
| You can adapt this file completely to your liking, but it should at least | ||
| contain the root `toctree` directive. | ||
|
|
||
| Sphinx documentation | ||
| ==================== | ||
|
|
||
| Add your content using ``reStructuredText`` syntax. See the | ||
| `reStructuredText <https://www.sphinx-doc.org/en/master/usage/restructuredtext/index.html>`_ | ||
| documentation for details. | ||
|
|
||
|
|
||
| .. toctree:: | ||
| :maxdepth: 2 | ||
| :caption: Contents: | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| #!/bin/zsh | ||
|
|
||
| # Script to install requirements for building Sphinx docs locally | ||
|
|
||
| set -e | ||
| # Check for Xcode Command Line Tools | ||
| if ! xcode-select -p &>/dev/null; then | ||
| echo "Xcode Command Line Tools not found. Installing..." | ||
| xcode-select --install | ||
| echo "Check for the install xcode dialog box. Please complete the Xcode Command Line Tools installation, then re-run this script." | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Check for Homebrew and install if missing | ||
| if ! command -v brew &>/dev/null; then | ||
| echo "Homebrew not found. Installing Homebrew..." | ||
| /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)" | ||
| # Add Homebrew to PATH for current session | ||
| if [[ -d "/opt/homebrew/bin" ]]; then | ||
| export PATH="/opt/homebrew/bin:$PATH" | ||
| elif [[ -d "/usr/local/bin" ]]; then | ||
| export PATH="/usr/local/bin:$PATH" | ||
| fi | ||
| fi | ||
|
|
||
| # Check for pyenv and install if missing | ||
| if ! command -v pyenv &>/dev/null; then | ||
| echo "pyenv not found. Installing with Homebrew..." | ||
| if ! command -v brew &>/dev/null; then | ||
| echo "Homebrew is required to install pyenv. Please install Homebrew first." | ||
| exit 1 | ||
| fi | ||
| brew install pyenv | ||
| fi | ||
|
|
||
| # Ensure desired Python version is installed via pyenv | ||
| PYTHON_VERSION="3.11.9" | ||
| if ! pyenv versions --bare | grep -qx "$PYTHON_VERSION"; then | ||
| echo "Installing Python $PYTHON_VERSION with pyenv..." | ||
| pyenv install "$PYTHON_VERSION" | ||
| fi | ||
|
|
||
| # Create virtual environment using pyenv if not exists | ||
| if [ ! -d "venv" ]; then | ||
| pyenv shell "$PYTHON_VERSION" | ||
| python -m venv venv-splice-docs | ||
| echo "Created virtual environment in ./venv using pyenv Python $PYTHON_VERSION" | ||
| fi | ||
|
|
||
| # Activate virtual environment | ||
| source venv/bin/activate | ||
|
|
||
| # Upgrade pip | ||
| pip install --upgrade pip | ||
|
|
||
| # Install additional requirements if requirements.txt exists | ||
| echo "Installing build requirements..." | ||
| if [ -f "requirements.txt" ]; then | ||
| pip install -r requirements.txt | ||
| fi | ||
|
|
||
| # Check for direnv and install if missing | ||
| if ! command -v direnv &>/dev/null; then | ||
| echo "direnv not found. Installing with Homebrew..." | ||
| if ! command -v brew &>/dev/null; then | ||
| echo "Homebrew is required to install direnv. Please install Homebrew first." | ||
| exit 1 | ||
| fi | ||
| brew install direnv | ||
| fi | ||
|
|
||
| export SPLICE_ROOT="${PWD}" | ||
|
|
||
| echo "Sphinx documentation build requirements installed." | ||
| # echo "To activate the virtual environment, run: source venv/bin/activate" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| @ECHO OFF | ||
|
|
||
| pushd %~dp0 | ||
|
|
||
| REM Command file for Sphinx documentation | ||
|
|
||
| if "%SPHINXBUILD%" == "" ( | ||
| set SPHINXBUILD=sphinx-build | ||
| ) | ||
| set SOURCEDIR=. | ||
| set BUILDDIR=_build | ||
|
|
||
| %SPHINXBUILD% >NUL 2>NUL | ||
| if errorlevel 9009 ( | ||
| echo. | ||
| echo.The 'sphinx-build' command was not found. Make sure you have Sphinx | ||
| echo.installed, then set the SPHINXBUILD environment variable to point | ||
| echo.to the full path of the 'sphinx-build' executable. Alternatively you | ||
| echo.may add the Sphinx directory to PATH. | ||
| echo. | ||
| echo.If you don't have Sphinx installed, grab it from | ||
| echo.https://www.sphinx-doc.org/ | ||
| exit /b 1 | ||
| ) | ||
|
|
||
| if "%1" == "" goto help | ||
|
|
||
| %SPHINXBUILD% -M %1 %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O% | ||
| goto end | ||
|
|
||
| :help | ||
| %SPHINXBUILD% -M help %SOURCEDIR% %BUILDDIR% %SPHINXOPTS% %O% | ||
|
|
||
| :end | ||
| popd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| pyyaml | ||
| sphinx | ||
| sphinx_rtd_theme | ||
| sphinx-copybutton | ||
| sphinx_reredirects | ||
| sphinxcontrib-openapi | ||
| sphinx-autobuild |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intended to be part of the PR, or maybe a local leftover? (I think it should not be part of the PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to get nix to run in GH Codespace. But it's not working. This is why I kept the PR as 'draft'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks