Skip to content

Fix container rename in participant Helm chart #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinflorian-da merged 1 commit into from
Jun 10, 2025
Merged

Fix container rename in participant Helm chart #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cluster/helm/splice-participant/templates/participant.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ spec:
spec:
{{- include "splice-util-lib.service-account" .Values | nindent 6 }}
containers:
- name: participant-1
- name: participant
image: "{{ .Values.imageRepo }}/canton-participant:{{ .Chart.AppVersion }}{{ ((.Values.imageDigests).canton_participant) }}"
{{- with .Values.imagePullPolicy }}
imagePullPolicy: {{ . }}
Expand Down
6 changes: 3 additions & 3 deletions cluster/helm/splice-participant/tests/participant_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ tests:
# Sanity check
- equal:
path: spec.template.spec.containers[0].name
value: participant-1
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

Copy link
Contributor Author

@martinflorian-da martinflorian-da Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I hate it

value: participant
# Labels on deployment
- isSubset:
path: metadata.labels
Expand Down Expand Up @@ -99,7 +99,7 @@ tests:
# Sanity check
- equal:
path: spec.template.spec.containers[0].name
value: participant-1
value: participant
# KMS config
- contains:
path: spec.template.spec.containers[0].env
Expand Down Expand Up @@ -139,7 +139,7 @@ tests:
# Sanity check
- equal:
path: spec.template.spec.containers[0].name
value: participant-1
value: participant
# multi-line env var
- contains:
path: spec.template.spec.containers[0].env
Expand Down
7 changes: 7 additions & 0 deletions docs/src/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@
Release Notes
=============

Upcoming
--------

- Deployment

- Fix a typo in the `splice-participant` Helm chart that caused the participant container to be named `participant-1` instead of `participant`.

0.4.1
-----

Expand Down