0.4.1: Essentially empty commit to fix upgrade tests #1054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DACH-NY/cn-test-failures#4495 This will produce a new commit on the release line branch that will not be on main, and so `get-snapshot-version` will correctly report `0.4.1` as the version to deploy. [force] Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
| # (when checking out Splice as a submodule, we might be losing the branch information). | ||
| # | ||
| sha=$(git rev-parse HEAD) | ||
| if ! (git branch -r --contains "$sha" | grep -q "\borigin/main\b"); then |
Contributor
Author
There was a problem hiding this comment.
So what is failing right now is that we check out commit edb2291be31694b9e55eba1ebb607c4eca1a1dbb which is also a commit on main, which then yields a fantasy version to deploy... all in all an artifact of switching repos and cutting 0.4.1 still on the old repo.
fayi-da
approved these changes
Jun 10, 2025
martinflorian-da
deleted the
martinflorian-da/cntf-4495-fix-0.4.1-upgrade-tests-simple
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/DACH-NY/cn-test-failures/issues/4495
This will produce a new commit on the release line branch that will not be on main, and so
get-snapshot-versionwill correctly report0.4.1as the version to deploy.Future release-line branches will be fine, this is just broken due to the repo migration.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines