Skip to content

Conversation

@martinflorian-da
Copy link
Contributor

  • Previous alert condition: if a single monitoring SV fails
  • New alert condition: if the most recent round that any monitoring SV has seen is over 30 minutes old

Tested updated query on grafana.

Not planning to backport; we get a false positive here fairly rarely and it only affects DevNet (which will get this in around a week anyway).

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@martinflorian-da martinflorian-da marked this pull request as ready for review June 10, 2025 12:32
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thank you

@martinflorian-da martinflorian-da merged commit a1a2dcf into main Jun 10, 2025
41 checks passed
@martinflorian-da martinflorian-da deleted the martinflorian-da/fix-round-not-advancing-alert-false-positive branch June 10, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants