[static] Add pulumi stack compatibility for v1 #1058
Conversation
Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
Co-authored-by: Itai Segall <itai.segall@digitalasset.com> Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
| } | ||
|
|
||
| /*https://github.com/pulumi/pulumi-kubernetes-operator/blob/master/docs/stacks.md*/ | ||
| export function createStackCRV1( |
There was a problem hiding this comment.
I assume you tested this? I know it's basically a revert, but to see that you have everything...
There was a problem hiding this comment.
Just by updating the generated files locally. Also pushed to my internal branch now
| export const OperatorDeploymentConfigSchema = z.object({ | ||
| operatorDeployment: z.object({ | ||
| reference: GitReferenceSchema, | ||
| // TODO(DACH-NY/canton-network-internal#544) - delete this and move the config back to the operator project |
There was a problem hiding this comment.
why are we adding this now? I read the issue but it doesn't actually state what the problem is.
There was a problem hiding this comment.
Sorry, didn't add the motivation to the issue.
Root cause is that the deployment stack follows main in our deployments, and the v2 CR is not compatible with the v2 definition.
So to first run it on our internal clusters we would need either to configure all the other clusters to not follow main or add a config flag.
There was a problem hiding this comment.
ah right makes sense, thx
Will set it to false just for devnet/testnet/mainnet once I update splice on the deployments.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines