Skip to content

Fix DamlCIUpgradeVotePreflightTest #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julientinguely-da merged 1 commit into from
Jun 11, 2025
Merged

Fix DamlCIUpgradeVotePreflightTest #1076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...decentralizedtrust/splice/integration/tests/upgrades/DamlCIUpgradeVotePreflightTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ class DamlCIUpgradeVotePreflightTest
val dropDownAction = new Select(webDriver.findElement(By.id("display-actions")))
dropDownAction.selectByValue("CRARC_SetConfig")

click on "action-change-dialog-proceed"
Copy link
Contributor

@martinflorian-da martinflorian-da Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you are sure this exists every time we run this test?

Copy link
Contributor Author

@julientinguely-da julientinguely-da Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's on devnet and testnet


// 20m to be effective so as to give enough time to upgrade the SV and Validator runbooks.
// The expiration doesn't matter so as long as it's enough for SVs to vote, but it needs to be less than the effective date.
Seq(
Expand Down