backport "SV1_SCAN_BIGQUERY deployment var; allow BQ-only cleanup (#1050)" to 0.4.1 #1088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SV1_SCAN_BIGQUERY env option * remove bqdatastream cleanup, just leave the user alive Revocations still not enough: - gcp:sql:User sv-1-user-bqdatastream deleting (1s) error: sdk-v2/provider2.go:566: sdk.helper_schema: Error, failed to deleteuser bqdatastream in instance sv-1-cn-apps-pg-2964ec6: googleapi: Error 400: Invalid request: failed to delete user bqdatastream: . role "bqdatastream" cannot be dropped because some objects depend on it Details: 32 objects in database scan_sv_1., invalid: provider=google-beta@8.32.1 Signed-off-by: Stephen Compall <stephen.compall@digitalasset.com>
stephencompall-DA
requested review from
OriolMunoz-da,
Copilot and
ray-roestenburg-da
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR backports support for the "SV1_SCAN_BIGQUERY" flag and refactors SQL command generation for Cloud SQL operations.
- Introduces a new environment flag (SV1_SCAN_BIGQUERY) to add conditional BigQuery scan configurations in svConfigs.ts.
- Adds a "retainOnDelete: true" option when creating a Cloud SQL replicator user and extracts common SQL command segments into the new function databaseCommandBracket in bigQuery.ts.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cluster/pulumi/common-sv/src/svConfigs.ts | Adds new BigQuery scan configuration controlled by the SV1_SCAN_BIGQUERY flag |
| cluster/pulumi/canton-network/src/bigQuery.ts | Refactors SQL command construction by extracting header/footer into a helper and adds a retention flag for Cloud SQL |
Comments suppressed due to low confidence (2)
cluster/pulumi/common-sv/src/svConfigs.ts:18
- [nitpick] Consider adding an inline comment to explain the purpose of the SV1_SCAN_BIGQUERY flag and its impact on scan configuration, which would improve code readability and maintenance.
const sv1ScanBigQuery = spliceEnvConfig.envFlag('SV1_SCAN_BIGQUERY', false);
cluster/pulumi/canton-network/src/bigQuery.ts:332
- [nitpick] Consider renaming the function 'databaseCommandBracket' to a more descriptive name (e.g., 'sqlCommandWrapper') along with renaming the returned 'header' and 'footer' variables to reflect their role in constructing SQL commands.
function databaseCommandBracket(postgres: CloudPostgres) {
stephencompall-DA
merged commit 7cfa5c1
into
release-line-0.4.1
110 of 113 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to use #1050 on devnet now, which is the fix for #1060.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines