Skip to content

0.4.1 backport: Move KMS integration tests to use keyring in da-cn-splice (#1123) #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinflorian-da merged 1 commit into from
Jul 1, 2025
Merged

0.4.1 backport: Move KMS integration tests to use keyring in da-cn-splice (#1123) #1261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions apps/app/src/test/resources/dumps/alice-kms-id-identity-dump.json
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions apps/app/src/test/resources/dumps/sv2-kms-id-identity-dump.json
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions ...decentralizedtrust/splice/integration/tests/ParticipantKmsIdentitiesIntegrationTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ class ParticipantKmsIdentitiesIntegrationTest extends IntegrationTest with Stand
.addConfigTransforms(
(_, conf) => ConfigTransforms.bumpCantonPortsBy(22_000)(conf),
(_, conf) => ConfigTransforms.bumpCantonDomainPortsBy(22_000)(conf),
// comment this to generate a fresh dump with fresh keys
(_, conf) =>
updateAllValidatorConfigs { case (name, c) =>
if (name == "aliceValidator") {
c.copy(
domains = c.domains.copy(extra = Seq.empty),
// comment this to generate a fresh dump with fresh keys
participantBootstrappingDump = Some(
ParticipantBootstrapDumpConfig
.File(
Expand Down Expand Up @@ -98,8 +98,8 @@ class ParticipantKmsIdentitiesIntegrationTest extends IntegrationTest with Stand
"EXTRA_PARTICIPANT_DB" -> ("participant_extra_" + dbsSuffix),
"KMS_TYPE" -> "gcp",
"KMS_LOCATION_ID" -> "us-central1",
"KMS_PROJECT_ID" -> "da-cn-shared",
"KMS_KEY_RING_ID" -> "kms-ci",
"KMS_PROJECT_ID" -> "da-cn-splice",
"KMS_KEY_RING_ID" -> "integration-tests",
),
)() {
startAllSync(sv1Backend, sv1ScanBackend, sv1ValidatorBackend)
Expand Down Expand Up @@ -169,8 +169,8 @@ class ParticipantKmsIdentitiesIntegrationTest extends IntegrationTest with Stand
)(
"KMS_TYPE" -> "gcp",
"KMS_LOCATION_ID" -> "us-central1",
"KMS_PROJECT_ID" -> "da-cn-shared",
"KMS_KEY_RING_ID" -> "kms-ci",
"KMS_PROJECT_ID" -> "da-cn-splice",
"KMS_KEY_RING_ID" -> "integration-tests",
) {
startAllSync(sv1Backend, sv1ScanBackend, sv1ValidatorBackend)

Expand Down
1 change: 1 addition & 0 deletions scripts/check-repo-names.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ function check_patterns_locally() {
'SpliceTests\.scala.*getMeterProvider\.get."cn_tests"' # test metrics
'^[^:]+package-lock\.json:.*"integrity"' # appears in hashes
'Preflight.*Test.*\.scala:.*s"https://cns' # hostnames in preflights
'Test.*\.scala:.*da-cn-splice' # GCP project we use for KMS keys used in integration tests
'cluster/images/splice-test-temp-runner-hook/index.js' # gha-runner-hook copied over
'apps/app/src/test/resources/dumps/.*-identity-dump.json' # encoded snapshots can randomly contain 'cn'
'token-standard/CHANGELOG.md'
Expand Down
Loading