-
Notifications
You must be signed in to change notification settings - Fork 59
Run Postgres 17 in tests and Postgres 14 nightly #1313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ff449cd
bump splice-test-postgres base pg image to 17
OriolMunoz-da 89771c4
[ci] run
OriolMunoz-da 3e80004
use the new pg 17 splice img
OriolMunoz-da 32f8bc2
[ci] run
OriolMunoz-da ded8f14
[ci] add a log to remove suspicion
OriolMunoz-da 2838ff0
I blame the heat for this mistake
OriolMunoz-da 40296f5
[ci] use the right version
OriolMunoz-da 6849a64
Merge branch 'main' into oriol/pg-17-test
OriolMunoz-da 37d9dcc
[ci] run
OriolMunoz-da 7e9b8eb
[ci] that file shouldn't change
OriolMunoz-da 98cbee6
[ci] bump flyway to latest 10.X (which supports pg 17)
OriolMunoz-da 43b5778
[ci] yolo flyway
OriolMunoz-da 452e862
Revert "[ci] yolo flyway"
OriolMunoz-da e84ddcf
ignore on canton
OriolMunoz-da 5041386
Merge branch 'main' into oriol/pg-17-test
OriolMunoz-da da8db56
[ci] run
OriolMunoz-da db0a53c
[ci] remove the version check
OriolMunoz-da 0c7e123
[ci] one more ignore
OriolMunoz-da 71c1bb1
[ci] one more ignore
OriolMunoz-da d20a8fb
[ci] fix more logs
OriolMunoz-da 13c7f3d
[ci] attempt to use simple postgres image
OriolMunoz-da 2a534ca
Merge branch 'main' into oriol/pg-17-test
OriolMunoz-da ec15f9f
[ci] bump max_onnections
OriolMunoz-da 77213fd
[ci] fix log ignore
OriolMunoz-da 0bffa3e
Merge branch 'main' into oriol/pg-17-test
OriolMunoz-da 6359f6c
[ci] run
OriolMunoz-da fa5dec0
[ci] these logs shouldn't need to be ignored anymore i guess
OriolMunoz-da aa0d8e8
Merge branch 'main' into oriol/pg-17-test
OriolMunoz-da 0f4c518
[ci] Run PG 14 nightly on wallclock tests
OriolMunoz-da 36c6ea9
[ci] also for local start-canton
OriolMunoz-da File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Wall Clock Tests with Postgres 14 | ||
|
|
||
| on: | ||
| # Scheduled workflows run on the latest commit on the default or base branch. | ||
| schedule: | ||
| - cron: "0 5 * * *" # Runs every night at 5AM UTC | ||
|
|
||
| permissions: | ||
| id-token: write # Required for GCP Workload Identity for failure notifications | ||
| contents: read | ||
|
|
||
| jobs: | ||
| scala_test_wall_clock_time: | ||
| uses: ./.github/workflows/build.scala_test.yml | ||
| with: | ||
| runs_on: self-hosted-k8s-large | ||
| test_names_file: 'test-full-class-names.log' | ||
| start_canton_options: -w | ||
| # TODO(DACH-NY/canton-network-node#10912) Investigate why things got slower | ||
| parallelism: 11 | ||
| test_name: wall-clock-time | ||
| with_gcp_creds: true | ||
| skip_if_regex: "\\[bft\\]" | ||
| commit_sha: "" | ||
| daml_base_version: "" | ||
| # This is the Postgres 14 image we built for testing. From 17 onwards, we use the official image. | ||
| postgres_image: us-central1-docker.pkg.dev/da-cn-shared/ghcr/digital-asset/decentralized-canton-sync-dev/docker/splice-test-postgres:0.3.12 | ||
| secrets: inherit | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -70,7 +70,7 @@ object CantonDependencies { | |
| lazy val hikaricp = "com.zaxxer" % "HikariCP" % "3.2.0" | ||
| lazy val h2 = "com.h2database" % "h2" % "2.1.210" | ||
| lazy val postgres = "org.postgresql" % "postgresql" % "42.7.3" | ||
| private val flyway_version = "10.12.0" | ||
| private val flyway_version = "10.22.0" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| lazy val flyway = "org.flywaydb" % "flyway-core" % flyway_version | ||
| lazy val flyway_postgresql = "org.flywaydb" % "flyway-database-postgresql" % flyway_version | ||
| lazy val oracle = "com.oracle.database.jdbc" % "ojdbc8" % "19.13.0.0.1" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the default:
splice/.github/workflows/build.yml
Line 25 in 189d4b0