Skip to content

Conversation

@martinflorian-da
Copy link
Contributor

@martinflorian-da martinflorian-da commented Jul 29, 2025

Part of https://github.com/DACH-NY/canton-network-internal/issues/1078

Tested the mock example in a cluster - works as expected.

The added flexibility seems more useful than building something just for blacklisting endpoints.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Part of #1078

[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
@martinflorian-da martinflorian-da force-pushed the martinflorian-da/cni-1078-istio-blacklist branch from 6e1c05c to e1a2db7 Compare July 29, 2025 09:25
Copy link
Contributor

@nicu-da nicu-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!
How is this related to #1078 though?

@martinflorian-da
Copy link
Contributor Author

thx! How is this related to #1078 though?

Ugh that should have been https://github.com/DACH-NY/canton-network-internal/issues/1078

[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
@martinflorian-da martinflorian-da force-pushed the martinflorian-da/cni-1078-istio-blacklist branch from ebcedf5 to 896993a Compare July 29, 2025 10:06
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thank you!

[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
… work

[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
@martinflorian-da martinflorian-da enabled auto-merge (squash) July 29, 2025 10:27
@martinflorian-da martinflorian-da merged commit 2ca658c into main Jul 29, 2025
39 checks passed
@martinflorian-da martinflorian-da deleted the martinflorian-da/cni-1078-istio-blacklist branch July 29, 2025 10:34
martinflorian-da added a commit that referenced this pull request Jul 29, 2025
#1715)

Backports #1715 so we can use on DevNet right away.

[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
martinflorian-da added a commit that referenced this pull request Jul 29, 2025
#1715) (#1716)

Backports #1715 so we can use on DevNet right away.

[static]

Signed-off-by: Martin Florian <martin.florian@digitalasset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants