Implement amulet form to action encoder #2471
Conversation
fayi-da
force-pushed
the
fayi/2413-amulet-form-to-action-encoder
branch
2 times, most recently
from
34be433 to
980d09c
Compare
fayi-da
force-pushed
the
fayi/2413-amulet-form-to-action-encoder
branch
from
980d09c to
5c01928
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements an amulet form to action encoder that builds AmuletConfig objects from configuration changes. The implementation enables conversion of form data to the required configuration format for submission.
- Adds a utility function to construct AmuletConfig objects from ConfigChange arrays
- Updates the transfer fee steps indexing to be 1-based for consistency
- Integrates the new encoder into the SetAmuletConfigRulesForm for action creation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| buildAmuletRulesConfigFromChanges.ts | New utility function that converts ConfigChange arrays to AmuletConfig objects |
| buildAmuletConfigChanges.ts | Fixes transfer fee steps indexing and adds required synchronizers handling |
| SetAmuletConfigRulesForm.tsx | Integrates the new encoder to create actions for form submission |
| buildAmuletRulesConfigFromChanges.test.tsx | Comprehensive test coverage for the new encoder utility |
apps/sv/frontend/src/__tests__/utils/buildAmuletRulesConfigFromChanges.test.tsx
Outdated
Show resolved
Hide resolved
fayi-da
force-pushed
the
fayi/2413-amulet-form-to-action-encoder
branch
from
5c01928 to
35d18eb
Compare
Fixes #2413 Signed-off-by: fayi-da <fayimora.femibalogun@digitalasset.com>
fayi-da
force-pushed
the
fayi/2413-amulet-form-to-action-encoder
branch
from
35d18eb to
ec7acf1
Compare
Signed-off-by: fayi-da <fayimora.femibalogun@digitalasset.com>
| defaultValues, | ||
| onSubmit: async ({ value }) => { | ||
| onSubmit: async ({ value: formData }) => { | ||
| console.log('submit amulet config form data: ', formData); |
There was a problem hiding this comment.
Should we leave the logs?
There was a problem hiding this comment.
Yeah i'll remove it in the PR that implements the full submission flow
| }, | ||
| }, | ||
| }; | ||
| console.log('action for submission', action); |
There was a problem hiding this comment.
Should we leave the logs?
There was a problem hiding this comment.
Yeah i'll remove it in the PR that implements the full submission flow
|
|
||
| const allSynchronizers = [ | ||
| ...new Set([...beforeRequiredSynchronizers, ...afterRequiredSynchronizers]), | ||
| ].sort(); |
There was a problem hiding this comment.
.sort is fishy as it's modifying the original array, I'd rather use the immutable .toSorted in modern code but in this case it's not all that important
Fixes #2413
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines