Improve sv network reset docs #2485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[static] Signed-off-by: Robert Autenrieth <robert.autenrieth@digitalasset.com>
rautenrieth-da
commented
Oct 1, 2025
| jq '.dso_rules.contract.payload.svs.[] | [.[1].name, .[1].svRewardWeight]' backup.json > weights_backup.json | ||
| jq '.dso_rules.contract.payload.svs.[] | [.[1].name, .[1].svRewardWeight]' current_state.json > weights_current.json | ||
| diff -C2 weights_backup.json weights_current.json |
Contributor
Author
There was a problem hiding this comment.
This is more verbose than the previous oneliner, but is also compatible with the fish shell, which doesn't have process substitution (the <() thing).
rautenrieth-da
commented
Oct 1, 2025
Comment on lines
+77
to
+78
| The reset should also preserve the amulet rules modulo cryptographic keys, i.e., the following diff should | ||
| only show changes to the dso and synchronizer namespaces: |
Contributor
Author
There was a problem hiding this comment.
Please confirm
[static] Signed-off-by: Robert Autenrieth <robert.autenrieth@digitalasset.com>
isegall-da
reviewed
Oct 1, 2025
isegall-da
approved these changes
Oct 1, 2025
Contributor
isegall-da
left a comment
isegall-da
left a comment
There was a problem hiding this comment.
LGTM, thanks. I'll refer the sv operators to this as well, in case anybody else has further comments before we merge.
Signed-off-by: Robert Autenrieth <robert.autenrieth@digitalasset.com>
[static] Signed-off-by: Robert Autenrieth <robert.autenrieth@digitalasset.com>
[static] Signed-off-by: Robert Autenrieth <robert.autenrieth@digitalasset.com>
rautenrieth-da
force-pushed
the
rautenrieth-da/improve-sv-reset-docs
branch
from
43acf90 to
2b450f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2060
Includes suggestions from the github issue and internal slack discussions.