[ci] Run sv rewards trigger during a random time between the round open and one tick #2669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicu-da
force-pushed
the
nicuda/rewards/hybrid
branch
2 times, most recently
from
cecf441 to
bb3c329
Compare
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/automation/RoundBasedTrigger.scala
Outdated
Show resolved
Hide resolved
...la/org/lfdecentralizedtrust/splice/sv/automation/singlesv/ReceiveSvRewardCouponTrigger.scala
Show resolved
Hide resolved
6 tasks
moritzkiefer-da
approved these changes
Oct 13, 2025
Contributor
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Nice thanks! Let's add some release notes for this. We already have people surprised there balance doesn't increase at least every 11min. This will just make it more extreme (which is fine just need to avoid surprises)
apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/EnvironmentDefinition.scala
Show resolved
Hide resolved
apps/app/src/main/scala/org/lfdecentralizedtrust/splice/config/ConfigTransforms.scala
Outdated
Show resolved
Hide resolved
…art and the duration of a tick Will extend to the other rewards triggers in another PR Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
nicu-da
force-pushed
the
nicuda/rewards/hybrid
branch
from
d04add5 to
f910d90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #2653 for #2143
Will extend to the other rewards triggers in another PR
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines