Disable UpdateHistory for SV and Splitwell apps #2675

OriolMunoz-da · 2025-10-13T14:54:01Z

preflight

Fixes #1572

This PR removes the UpdateHistory from:

sv-app SvSvStore
sv-app SvDsoStore
SplitwellStore

Includes also:

Separate UpdateHistory from stores. The alternative seemed to involve cake pattern / visitor pattern / instance matching when registering the ingestion service. This seems way cleaner.
No more passing around Storage and throwing on every spot that can only work with DbStorage
No more Option[UpdateHistory] metrics, now that UpdateHistory is separate from stores
See also Make scanConfig mandatory in SV app #2686 for more annoyance

[ci] Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da · 2025-10-14T12:22:27Z

...n/scala/org/lfdecentralizedtrust/splice/sv/automation/singlesv/SequencerPruningTrigger.scala

+      scanConnection <- createScanConnection()
+      recordTimeRangeO <- scanConnection
+        .getMigrationInfo(migrationId)


pay attention to this change

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da · 2025-10-15T10:50:17Z

...main/resources/db/migration/canton-network/postgres/stable/V047__truncate_sv_app_history.sql

+from update_history_descriptors;
+
+IF descriptors  = '{"DbSvDsoStore", "DbSvSvStore"}' THEN
+    RAISE NOTICE 'Truncating update history tables as only SV app descriptors are present. Descriptors: %', descriptors::text;


fun fact, flyway logs these, very useful!

OriolMunoz-da · 2025-10-15T10:50:38Z

...main/resources/db/migration/canton-network/postgres/stable/V047__truncate_sv_app_history.sql

+select array_agg(store_name order by store_name) into descriptors
+from update_history_descriptors;
+
+IF descriptors  = '{"DbSvDsoStore", "DbSvSvStore"}' THEN


This is more strict than it needs to be - some of the descriptors in the update_history_descriptors might not be used by the tables that we want to truncate.

Also, in case someone has a very stupid production setup where multiple apps write into the same database, this will fail to delete the unused data.

I still think it's fine as is, in real setups it should work and worst case it just leaves around unused data.

rautenrieth-da

Thanks! Nice cleanup of the useless case dbStorage: DbStorage 🎉

rautenrieth-da · 2025-10-15T12:24:43Z

...main/resources/db/migration/canton-network/postgres/stable/V047__truncate_sv_app_history.sql

+select array_agg(store_name order by store_name) into descriptors
+from update_history_descriptors;
+
+IF descriptors  = '{"DbSvDsoStore", "DbSvSvStore"}' THEN


This is more strict than it needs to be - some of the descriptors in the update_history_descriptors might not be used by the tables that we want to truncate.

Also, in case someone has a very stupid production setup where multiple apps write into the same database, this will fail to delete the unused data.

I still think it's fine as is, in real setups it should work and worst case it just leaves around unused data.

rautenrieth-da · 2025-10-15T12:28:24Z

...esources/db/migration/canton-network/postgres/stable/V051__truncate_sv_splitwell_history.sql

+    EXECUTE 'TRUNCATE TABLE update_history_assignments CASCADE';
+    EXECUTE 'TRUNCATE TABLE update_history_unassignments CASCADE';
+    EXECUTE 'TRUNCATE TABLE update_history_backfilling CASCADE';
+    EXECUTE 'TRUNCATE TABLE update_history_creates CASCADE';


Note to self: The acs_snapshot_data table has a foreign key constraint to update_history_creates. We don't need to truncate acs_snapshot_data because the SV app doesn't write any data into it (and we'd rather fail if there is any unexpected data in there after all).

apps/splitwell/src/main/scala/org/lfdecentralizedtrust/splice/splitwell/SplitwellApp.scala

...n/scala/org/lfdecentralizedtrust/splice/sv/automation/singlesv/SequencerPruningTrigger.scala

...allet/src/main/scala/org/lfdecentralizedtrust/splice/wallet/ExternalPartyWalletService.scala

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

* Make scanConfig mandatory in SV app [ci] let's see what breaks Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com> * [ci] docs Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com> * [ci] run pls gh Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com> * update helm json schema Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com> * [ci] release notes fix Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com> --------- Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

ray-roestenburg-da

Thanks

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

…abs/splice into oriol/non-optional-metrics Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da · 2025-11-18T15:37:24Z

/cluster_test

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

github-actions · 2025-11-18T15:37:55Z

Deploy cluster test triggered for Commit 96524d57959afe97838bd2a09cb6c3af039b200f in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/41188

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da · 2025-11-18T16:31:00Z

/cluster_test

github-actions · 2025-11-18T16:31:31Z

Deploy cluster test triggered for Commit 0cb1b63238679493d19a8706148f0406104345e6 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/41198

OriolMunoz-da added 2 commits October 13, 2025 14:52

Disable UpdateHistory for SV and Splitwell apps

7b8dc43

[ci] Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] when has lazy not fixed a npe

ad2b047

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da commented Oct 14, 2025

View reviewed changes

OriolMunoz-da added 5 commits October 14, 2025 12:25

[ci] remove register duplicates

3aefc00

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] DbStorage errywhere

695a66e

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] Docs

c1a2fcf

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

Merge branch 'main' into oriol/non-optional-metrics

2827e8b

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] run pls gh

2ff977b

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da marked this pull request as ready for review October 14, 2025 13:14

OriolMunoz-da requested review from rautenrieth-da and ray-roestenburg-da October 14, 2025 13:14

OriolMunoz-da changed the title ~~Disable UpdateHistory for SV and Splitwell apps~~ [wait until 0.4.21] Disable UpdateHistory for SV and Splitwell apps Oct 15, 2025

OriolMunoz-da added 2 commits October 15, 2025 09:38

Merge branch 'main' into oriol/non-optional-metrics

428dbac

[ci] truncate tables for sv app

4a38d9f

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da commented Oct 15, 2025

View reviewed changes

rautenrieth-da approved these changes Oct 15, 2025

View reviewed changes

OriolMunoz-da self-assigned this Oct 15, 2025

OriolMunoz-da added the sprint2541 label Oct 15, 2025

martinflorian-da mentioned this pull request Oct 16, 2025

Tracking: PR's on hold until after 0.5.x migration #2732

Closed

OriolMunoz-da added 2 commits October 20, 2025 11:44

Merge branch 'main' into oriol/non-optional-metrics

f1f167a

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

fix migration

2a99661

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da changed the title ~~[wait until 0.4.21] Disable UpdateHistory for SV and Splitwell apps~~ [wait until 0.5.1] Disable UpdateHistory for SV and Splitwell apps Oct 20, 2025

OriolMunoz-da added 2 commits October 20, 2025 12:05

[ci] chekc update history of externals

3f938d6

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

ray-roestenburg-da approved these changes Oct 20, 2025

View reviewed changes

OriolMunoz-da added 4 commits November 11, 2025 12:00

Merge branch 'main' into oriol/non-optional-metrics

865e29e

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

Merge branch 'oriol/non-optional-metrics' of github.com:hyperledger-l…

f02341e

…abs/splice into oriol/non-optional-metrics Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] move migration

7ee24fc

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] update comments

44a8269

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] fixes

f1ad5c7

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da added the sprint2545 label Nov 11, 2025

OriolMunoz-da added 4 commits November 11, 2025 15:51

[ci] fix metrics issue?

eadbf72

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] is this the problem? am i the problem?

7218048

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] fix it properly

32c9f2d

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] not unused

d652463

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da changed the title ~~[wait until 0.5.1] Disable UpdateHistory for SV and Splitwell apps~~ Disable UpdateHistory for SV and Splitwell apps Nov 18, 2025

Merge branch 'main' into oriol/non-optional-metrics

96524d5

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da added 2 commits November 18, 2025 15:37

[static] run

1ce8dc5

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] run

6e84fe3

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

[ci] i cannot have nice things for too long

0cb1b63

Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>

OriolMunoz-da merged commit 0865984 into main Nov 18, 2025
63 checks passed

OriolMunoz-da deleted the oriol/non-optional-metrics branch November 18, 2025 17:54

Disable UpdateHistory for SV and Splitwell apps #2675

Disable UpdateHistory for SV and Splitwell apps #2675

Uh oh!

Conversation

OriolMunoz-da commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OriolMunoz-da Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

OriolMunoz-da Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

OriolMunoz-da Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

rautenrieth-da Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

rautenrieth-da left a comment

Choose a reason for hiding this comment

Uh oh!

rautenrieth-da Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

rautenrieth-da Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ray-roestenburg-da left a comment

Choose a reason for hiding this comment

Uh oh!

OriolMunoz-da commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

OriolMunoz-da commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

OriolMunoz-da commented Oct 13, 2025 •

edited

Loading