Skip to content

shorten generated KMS SA name if > 30 characters (#2679) #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephencompall-DA merged 1 commit into from
Oct 13, 2025
Merged

shorten generated KMS SA name if > 30 characters (#2679) #2682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions cluster/pulumi/common/src/participantKms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ const createKmsServiceAccount = (
};
const serviceAccountName = migrationIdSuffixed(
`${CLUSTER_BASENAME}-${xns.logicalName}-kms`,
migrationId
migrationId,
true
);
const kmsServiceAccount = new GcpServiceAccount(serviceAccountName, {
accountId: serviceAccountName,
Expand Down Expand Up @@ -109,5 +110,16 @@ export const getParticipantKmsHelmResources = (
};
};

const migrationIdSuffixed = (name: string, migrationId?: DomainMigrationIndex) =>
migrationId != undefined ? `${name}-migration-${migrationId}` : name;
function migrationIdSuffixed(
name: string,
migrationId?: DomainMigrationIndex,
limit30?: boolean
): string {
if (migrationId === undefined) {
return name;
}
const longName = `${name}-migration-${migrationId}`;
// error: gcp:serviceaccount/account:Account
// resource..."account_id"...must be between 6 and 30 characters long
return limit30 && longName.length > 30 ? `${name}-mg-${migrationId}` : longName;
}