Skip to content

Conversation

@isegall-da
Copy link
Contributor

Fixes https://github.com/DACH-NY/canton-network-internal/issues/2181

Will add a dashboard and alerts in a separate PR, but I don't consider that a release blocker so didn't want to delay this PR

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
…trics

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Copy link
Contributor

@martinflorian-da martinflorian-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, thanks a lot!

Did you sanity check on a cluster grafana that the metrics look as expected? Might be a good TODO before cutting the release, in case we did miss something here.

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
@isegall-da
Copy link
Contributor Author

Did you sanity check on a cluster grafana that the metrics look as expected? Might be a good TODO before cutting the release, in case we did miss something here.

Yes, I did. Didn't trust myself enough to even write the test before looking at Grafana for sanity ;)

…trics

Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
Signed-off-by: Itai Segall <itai.segall@digitalasset.com>
@isegall-da isegall-da merged commit 265fc1a into main Oct 14, 2025
57 checks passed
@isegall-da isegall-da deleted the isegall/price-metrics branch October 14, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants