Skip to content

IGNORE: CI for Daml: Fix ClaimExpiredRewards for ValidatorLicense weight #3181 #3191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
meiersi-da wants to merge 9 commits into from
Closed

IGNORE: CI for Daml: Fix ClaimExpiredRewards for ValidatorLicense weight #3181 #3191

meiersi-da wants to merge 9 commits into from

Conversation

@meiersi-da
Copy link
Contributor

@meiersi-da meiersi-da commented Nov 13, 2025

CI run for Daml: Fix ClaimExpiredRewards for ValidatorLicense weight

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@dfordivam
Daml: Add weight, kind to ValidatorLicense, and SV grant license support
10f85a5 
PR reviewed in #2903
CI run #3093

Squash commit created by rebasing 5e8d90e7f over f47f017

Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Add unit tests for DsoRules_ClaimExpiredRewards
9d61519 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Sum ValidatorLicense weights in {AmuletRules,DsoRules}_ClaimExpiredRe…
051fd61 
…wards

Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Tests for non-default weights in ClaimExpiredRewards
b2ed843 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update daml/dars
c033e90 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Deprecate AmuletRules_ClaimExpiredRewards
16c94f0 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Use fetchUncheckedButArchiveLater
a05701b 
Signed-off-by: Divam <dfordivam@gmail.com>
@dfordivam
Update dars+lock
5612a48 
Signed-off-by: Divam <dfordivam@gmail.com>
@meiersi-da meiersi-da force-pushed the meiersi/dn/feature-cip-73 branch from 2c829da to 0f126e6 Compare November 14, 2025 15:32
@meiersi-da
[ci]
593461d 
Signed-off-by: Simon Meier <simon@digitalasset.com>
@meiersi-da meiersi-da force-pushed the meiersi/dn/cip-73-daml-claim-expired-reward-fixes branch from cb1515a to 593461d Compare November 14, 2025 15:36
dfordivam added a commit to obsidiansystems/canton-splice that referenced this pull request Nov 17, 2025
@dfordivam
Daml: Fix DsoRules_ClaimExpiredRewards for ValidatorLicense weight
4864f05 
And deprecate AmuletRules_ClaimExpiredRewards

PR reviewed in hyperledger-labs#3181
CI run hyperledger-labs#3191

Squashed commit created from 9d61519~18ce4659

Signed-off-by: Divam <dfordivam@gmail.com>
@meiersi-da meiersi-da force-pushed the meiersi/dn/feature-cip-73 branch from 0f126e6 to 4864f05 Compare November 17, 2025 06:57
@meiersi-da
Copy link
Contributor Author

meiersi-da commented Nov 17, 2025

Closing as this has now been merged into the integration branch

@meiersi-da meiersi-da closed this Nov 17, 2025
dfordivam added a commit to obsidiansystems/canton-splice that referenced this pull request Nov 21, 2025
@dfordivam
Daml: Fix DsoRules_ClaimExpiredRewards for ValidatorLicense weight
a5157b2 
And deprecate AmuletRules_ClaimExpiredRewards

PR reviewed in hyperledger-labs#3181
CI run hyperledger-labs#3191

Squashed commit created from 9d61519~18ce4659

Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam added a commit that referenced this pull request Nov 25, 2025
@dfordivam
Daml: Fix DsoRules_ClaimExpiredRewards for ValidatorLicense weight
9801b32 
And deprecate AmuletRules_ClaimExpiredRewards

PR reviewed in #3181
CI run #3191

Squashed commit created from 9d61519~18ce4659

Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam added a commit that referenced this pull request Dec 1, 2025
@dfordivam
Daml: Fix DsoRules_ClaimExpiredRewards for ValidatorLicense weight
2f18daf 
And deprecate AmuletRules_ClaimExpiredRewards

PR reviewed in #3181
CI run #3191

Squashed commit created from 9d61519~18ce4659

Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam added a commit that referenced this pull request Dec 8, 2025
@dfordivam
Daml: Fix DsoRules_ClaimExpiredRewards for ValidatorLicense weight
9712ace 
And deprecate AmuletRules_ClaimExpiredRewards

PR reviewed in #3181
CI run #3191

Squashed commit created from 9d61519~18ce4659

Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam added a commit that referenced this pull request Dec 9, 2025
@dfordivam
Daml: Fix DsoRules_ClaimExpiredRewards for ValidatorLicense weight
c0a4c09 
And deprecate AmuletRules_ClaimExpiredRewards

PR reviewed in #3181
CI run #3191

Squashed commit created from 9d61519~18ce4659

Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam added a commit that referenced this pull request Dec 15, 2025
@dfordivam
Daml: Fix DsoRules_ClaimExpiredRewards for ValidatorLicense weight
bf5704d 
And deprecate AmuletRules_ClaimExpiredRewards

PR reviewed in #3181
CI run #3191

Squashed commit created from 9d61519~18ce4659

Signed-off-by: Divam <dfordivam@gmail.com>
dfordivam added a commit that referenced this pull request Dec 16, 2025
@dfordivam
Daml: Fix DsoRules_ClaimExpiredRewards for ValidatorLicense weight
e6a73a6 
And deprecate AmuletRules_ClaimExpiredRewards

PR reviewed in #3181
CI run #3191

Squashed commit created from 9d61519~18ce4659

Signed-off-by: Divam <dfordivam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meiersi-da @dfordivam