Skip to content

Conversation

@jose-velasco-ieu
Copy link
Contributor

Description

This PR resolves #3264 by improving the performance, robustness, and documentation of the unclaimed_sv_rewards.py script.

Key changes

  • Parallelized Scan processing by splitting the requested time range into
    independent time chunks.
  • Added support for multiple Scan URLs, used in a round-robin fashion per
    chunk to increase throughput and provide failover.
  • Implemented retry logic with automatic Scan server rotation.
  • Tuned default concurrency-related parameters based on empirical testing.
  • Improved CLI help messages for clarity and correctness.
  • Added and updated RST documentation for the script.
  • Updated integration tests and performed minor cleanup.

Concurrency model (high level)

The script divides the input time range into small chunks that can be
processed independently. Each chunk is handled asynchronously and uses a
rotated Scan URL. Results are merged sequentially to ensure deterministic
behavior regardless of concurrency level.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@jose-velasco-ieu jose-velasco-ieu changed the title issue-3264: improve performance and documentation of unclaimed_sv_rewards Resolve issue-3264: improve performance and documentation of unclaimed_sv_rewards Dec 12, 2025
Signed-off-by: Jose Velasco <[email protected]>
Signed-off-by: Jose Velasco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unclaimed_rewards.py: improve throughput and robustness

4 participants