-
Notifications
You must be signed in to change notification settings - Fork 59
Support transfers with 24h validity period #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cocreature/no-fees
Are you sure you want to change the base?
Conversation
a2de820 to
afd6585
Compare
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Directionally right. Two main comments are:
- avoid contention with archival of
AmuletRulesdue to config changes - try to change code so that it only uses the newly introduced choices
token-standard/splice-token-standard-test/daml/Splice/Testing/Registries/AmuletRegistry.daml
Outdated
Show resolved
Hide resolved
token-standard/splice-token-standard-test/daml/Splice/Testing/Registries/AmuletRegistry.daml
Show resolved
Hide resolved
|
@meiersi-da Ready for another review when you have the time, design doc not yet updated. |
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Good improvements!
Let me know when you'd like another review.
token-standard/splice-token-standard-test/daml/Splice/Testing/Registries/AmuletRegistry.daml
Outdated
Show resolved
Hide resolved
d7dfc25 to
185f12a
Compare
185f12a to
dc58402
Compare
|
@meiersi-da ready for another review, I've rebased it on a branch that just enforces the additional restrictions on |
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. I believe we've converged on the change.
token-standard/splice-token-standard-test/daml/Splice/Tests/TestAmuletTokenDvP.daml
Show resolved
Hide resolved
a9c119f to
2896359
Compare
82d47f1 to
6771657
Compare
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
6771657 to
f19898b
Compare
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
d039d03 to
d58851c
Compare
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
[ci] Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Current state:
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines