Skip to content

Conversation

@moritzkiefer-da
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da commented Jan 8, 2026

Current state:

  1. Only handles transfers
  2. Does not handle all edge cases like aborting two-step transfers.
  3. Only one smoke test, needs lot more testing.
  4. AmuletRules choices not yet wired up to DsoRules.

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/transfer-24h branch from a2de820 to afd6585 Compare January 9, 2026 12:50
Copy link
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Directionally right. Two main comments are:

  • avoid contention with archival of AmuletRules due to config changes
  • try to change code so that it only uses the newly introduced choices

@moritzkiefer-da
Copy link
Contributor Author

@meiersi-da Ready for another review when you have the time, design doc not yet updated.

Copy link
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Good improvements!

Let me know when you'd like another review.

@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/transfer-24h branch from d7dfc25 to 185f12a Compare January 13, 2026 15:26
@moritzkiefer-da moritzkiefer-da changed the base branch from main to cocreature/no-fees January 13, 2026 15:26
@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/transfer-24h branch from 185f12a to dc58402 Compare January 13, 2026 17:22
@moritzkiefer-da
Copy link
Contributor Author

@meiersi-da ready for another review, I've rebased it on a branch that just enforces the additional restrictions on AmuletConfig. Daml tests do pass now but definitely needs a lot more tests.

Copy link
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I believe we've converged on the change.

@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/no-fees branch 10 times, most recently from a9c119f to 2896359 Compare January 21, 2026 08:52
@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/transfer-24h branch 4 times, most recently from 82d47f1 to 6771657 Compare January 22, 2026 12:44
[ci]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/transfer-24h branch from 6771657 to f19898b Compare January 22, 2026 14:39
[ci]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
[ci]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/transfer-24h branch from d039d03 to d58851c Compare January 23, 2026 14:55
[ci]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
[ci]

Signed-off-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants