Skip to content

Conversation

@isegall-da
Copy link
Contributor

@isegall-da isegall-da commented Jan 14, 2026

A segment should be "the initial ACS, and all following updates". Now that the ACS is <=t1, segments should be (t1, t2] (and not [t1, t2) as they were).

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Itai Segall <[email protected]>
Signed-off-by: Itai Segall <[email protected]>
@isegall-da isegall-da marked this pull request as ready for review January 14, 2026 18:04
Copy link
Contributor

@ray-roestenburg-da ray-roestenburg-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Itai Segall <[email protected]>
@isegall-da isegall-da enabled auto-merge (squash) January 14, 2026 18:23
@isegall-da isegall-da merged commit 60a163a into main Jan 14, 2026
62 checks passed
@isegall-da isegall-da deleted the isegall/bulk-acs-semantics branch January 14, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants