Skip to content

Fix pg14 tests #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OriolMunoz-da merged 1 commit into from
Jan 16, 2026
Merged

Fix pg14 tests #3574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/build.scala_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ on:
required: false
type: string
default: "postgres:17"
postgres_init_args:
description: "Additional arguments to pass to Postgres on initialization via POSTGRES_INITDB_ARGS"
required: false
type: string
default: "-c max_connections=16000"

jobs:

Expand Down Expand Up @@ -117,7 +122,7 @@ jobs:
image: ${{ inputs.postgres_image }}
env:
POSTGRES_PASSWORD: postgres
POSTGRES_INITDB_ARGS: "-c max_connections=16000"
POSTGRES_INITDB_ARGS: ${{ inputs.postgres_init_args }}

steps:

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build.wallclock_pg14.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,7 @@ jobs:
commit_sha: ""
daml_base_version: ""
# This is the Postgres 14 image we built for testing. From 17 onwards, we use the official image.
# It doesn't support `-c` init args. `max_connections` is set in the image itself.
postgres_image: us-central1-docker.pkg.dev/da-cn-shared/ghcr/digital-asset/decentralized-canton-sync-dev/docker/splice-test-postgres:0.3.12
postgres_init_args: ""
secrets: inherit