Added x-source-ui header, logged in http server metrics #3581
Conversation
ray-roestenburg-da
force-pushed
the
ray/scan_usage/3571
branch
3 times, most recently
from
0c67818 to
1121b31
Compare
|
|
ray-roestenburg-da
force-pushed
the
ray/scan_usage/3571
branch
2 times, most recently
from
f1543fd to
5e2e0bc
Compare
| logger.debug( | ||
| s"Request from UI($customSourceUiHeader: $sourceUi): service = $service, operation= $operation" | ||
| ) |
There was a problem hiding this comment.
In the end, what we want is mostly stats on endpoints that are called not from the UI
There was a problem hiding this comment.
You have those too implicitly but I can add a log for when the header is missing 👍
There was a problem hiding this comment.
Added a log debug without source UI header.
ray-roestenburg-da
force-pushed
the
ray/scan_usage/3571
branch
from
5e2e0bc to
0b67a7d
Compare
ray-roestenburg-da
force-pushed
the
ray/scan_usage/3571
branch
from
72fd22d to
842f819
Compare
Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
ray-roestenburg-da
force-pushed
the
ray/scan_usage/3571
branch
from
842f819 to
8a7ee9e
Compare
|
/cluster_test |
|
Deploy cluster test triggered for Commit 8a7ee9e111c8faf633e1ff3ccb4bffe676036584 in , please contact a Contributor to approve it in CircleCI: https://app.circleci.com/pipelines/github/DACH-NY/canton-network-internal/48112 |
| Operation -> "Descriptor of the HTTP operation done, as per the OpenAPI spec", | ||
| Status -> "Status of the HTTP request: completed, rejected, failure", |
There was a problem hiding this comment.
What are the implications of this change? Do we need to adjust some dashboard?
There was a problem hiding this comment.
no is just reusing strings
There was a problem hiding this comment.
Ah, of course, missed that you also dropped the "", I thought you changed the label itself...
Fixes #3571
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines