Use GetContract as fallback for token standard context endpoints on Scan #3595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
OriolMunoz-da
commented
Jan 20, 2026
Contributor
Author
There was a problem hiding this comment.
OriolMunoz-da
commented
Jan 20, 2026
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/MultiDomainAcsStore.scala
Show resolved
Hide resolved
OriolMunoz-da
commented
Jan 20, 2026
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/ContractFetcher.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
OriolMunoz-da
commented
Jan 20, 2026
...ommon/src/main/scala/org/lfdecentralizedtrust/splice/automation/UpdateIngestionService.scala
Show resolved
Hide resolved
OriolMunoz-da
commented
Jan 20, 2026
|
|
||
| "Token Standard Transfers should" should { | ||
|
|
||
| "TransferInstruction context can be fetched from Scan even if it's not yet ingested into the store" in { |
Contributor
Author
There was a problem hiding this comment.
this test wants the fallback to be enabled and the validity to be long enough, whereas this assertion wants to see an archival immediately, which is in opposition to what this test wants, so I had to move this into a different file
moritzkiefer-da
approved these changes
Jan 20, 2026
Contributor
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
There was a problem hiding this comment.
Nice work, thanks!
...ommon/src/main/scala/org/lfdecentralizedtrust/splice/automation/UpdateIngestionService.scala
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/db/DbMultiDomainAcsStore.scala
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/MultiDomainAcsStore.scala
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/ContractFetcher.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/ContractFetcher.scala
Outdated
Show resolved
Hide resolved
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/store/ContractFetcher.scala
Outdated
Show resolved
Hide resolved
...fdecentralizedtrust/splice/integration/tests/TokenStandardFetchFallbackIntegrationTest.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
…...... Signed-off-by: Oriol Muñoz <oriol.munoz@digitalasset.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/DACH-NY/canton-network-internal/issues/2817#issuecomment-3760837095
Fetches from ledger if not found for:
(I didn't find any other applicable ones)