Wallet UI support for minting delegations management #3601

dfordivam · 2026-01-20T09:32:48Z

Fixes #3553

Provides separate tables for managing the proposal and delegations
Each table shows all the fields of the appropriate item
Provide control buttons corresponding to known actions for proposal and delegations
- Proposals: Accept/Reject
- Delegations: Withdraw
All actions are confirmed
- When proposal will update an existing delegation, the confirmation dialogue shows the details
Allows display of proposals/delegations from parties that are not fully onboarded, with certain controls deactivated as appropriate

PR author is https://github.com/adetokunbo , I have pushed this branch and created this PR for running CI

Pull Request Checklist

Cluster Testing

If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

Include any change that might be observable by our partners or affect their deployment in the release notes.
Specify fixed issues with Fixes #n, and mention issues worked on using #n
Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

adetokunbo · 2026-01-21T03:46:14Z

This comment and the next two contain screenshots demonstrating this change

1. Some delegation proposals are pending approval

01-delegations-after-setup-26-01-20-11:0:18 439

2. One of them is approved

02-delegations-accept-proposal-26-01-20-11:0:19 380

3. View of the confirmation dialog as the next one is being approved

03-delegations-confirm-accept-proposal-26-01-21-3:18:4 197

4. After the second is approved

04-delegations-accept-again-26-01-20-11:0:20 339

adetokunbo · 2026-01-21T03:47:31Z

5. View of confirmation dialog as one of the approved delegations is withdrawn

12-delegations-confirm-withdraw-delegation-26-01-21-3:18:5 188

6. After the delegation is withdrawn

05-delegations-withdraw-delegation-26-01-20-11:0:21 531

7. View of confirmation dialog as the remaining proposal is rejected

06-delegations-confirm-withdraw-proposal-26-01-21-3:18:6 185

8. After that proposal is rejected

07-delegations-reject-proposal-26-01-20-11:0:23 379

adetokunbo · 2026-01-21T03:49:02Z

9. A new proposal and delegation appear from users that have not completed onboarding

08-delegations-non-onboarded-proposal-and-delegation-26-01-20-11:0:33 250

10. A proposal appears from a user that updates their active delegation

09-delegations-replacement-proposal-appears-26-01-20-11:0:36 704

11. View of the confirmation dialog when accepting the updating proposal

10-delegations-accept-replacement-proposal-26-01-21-3:18:21 81

12. After the update is accepted

11-delegations-after-accept-replacement-26-01-20-11:0:37 817

meiersi-da

Very nice work @dfordivam and @adetokunbo. Functionally we're close except for the wording.

The codestyle also looks good, but I'd appreciate if you @ray-roestenburg-da could have a peek yourself or ask somebody from your team to approve as the codeowners.

I've also pinged @waynecollier-da to have a look at the UI screenshots. (Thanks for providing them @adetokunbo 🙏 )

meiersi-da · 2026-01-22T10:37:51Z

apps/wallet/frontend/src/contexts/WalletServiceContext.tsx

+        const res = await walletClient.listMintingDelegations();
+        return res.delegations.map(d => ({
+          contract: Contract.decodeOpenAPI(d.contract, MintingDelegation),
+          beneficiaryOnboarded: d.beneficiary_onboarded,


Suggested change

beneficiaryOnboarded: d.beneficiary_onboarded,

beneficiaryHosted: d.beneficiary_hosted,

In Canton docs, we talk about a validator node hosting parties.

The Splice Amulet Wallet UI uses "onboarded" to mean that a party has an active WalletAppInstall contract.

Let's talk about "hosting" here.

meiersi-da · 2026-01-22T10:38:43Z

apps/wallet/frontend/src/routes/delegations.tsx

+      marginTop={4}
+    >
+      <Typography variant="h4" id="proposals-label">
+        Proposed


Suggested change

Proposed

Proposed Minting Delegations

the goal is to make clear what kind of delegations are seen here

meiersi-da · 2026-01-22T10:40:08Z

apps/wallet/frontend/src/routes/delegations.tsx

+            <TableRow>
+              <TableCell>Beneficiary</TableCell>
+              <TableCell>Onboarded</TableCell>
+              <TableCell>Max Amulets</TableCell>


Suggested change

<TableCell>Max Amulets</TableCell>

<TableCell>Merge Threshold</TableCell>

the merge logic does not maintain a strict max

when using "Amulet" care must be taken to read the name from the config, so that the wallet properly shows when configured as a "Canton Coin" wallet.

meiersi-da · 2026-01-22T10:43:16Z

apps/wallet/frontend/src/routes/delegations.tsx

+          <TableHead>
+            <TableRow>
+              <TableCell>Beneficiary</TableCell>
+              <TableCell>Onboarded</TableCell>


I'd drop this column, and instead add an annotation toe beneficiary parties that are not hosted on the validator node. Possible options:

show a warning icon before the party-id with a hover text "Minting delegations do not work for this party, as it is not hosted on this validator node."

show the warning text inline below the party name.

Done, opted for the warning icon with a hover

meiersi-da · 2026-01-22T10:43:30Z

apps/wallet/frontend/src/routes/delegations.tsx

+      )}
+
+      <Typography variant="h4" id="delegations-label">
+        Active


Suggested change

Active

Active Minting Delegations

add a hover or inline text "The validator automates minting and merging holdings for the beneficiaries of the delegations below."

Done: went with a hover

meiersi-da · 2026-01-22T10:46:21Z

apps/wallet/frontend/src/routes/delegations.tsx

+          conditions={[
+            {
+              disabled: !beneficiaryOnboarded,
+              reason: 'Beneficiary is not onboarded',


I assume this is shown on hover, is it?

side note: change everywhere to "not hosted on this validator"

It is, and the message has been updated
Done

pawelperek-da · 2026-01-22T18:07:04Z

apps/wallet/frontend/src/contexts/WalletServiceContext.tsx

+  beneficiaryOnboarded: boolean;
+}
+
+export interface MintingDelegationProposalWithOnboardedStatus {


I think this interface is not used anywhere, right?

Correct; sorry that should have been cleaned up better.
Removed

pawelperek-da · 2026-01-22T18:13:57Z

apps/wallet/frontend/src/routes/delegations.tsx

+  useWalletClient,
+} from '../contexts/WalletServiceContext';
+
+export const shortenPartyId = (partyId: string): string => {


We already have an implementation of the shortenPartyId in TransactionHistory.tsx which I'd love to reuse somehow, perhaps move to src/utils?

While we're at it, please replace elements.length == 2 with elements.length === 2

Done, moved to src/utils/partyId.ts

pawelperek-da

Thank you @dfordivam and @adetokunbo, the UI code looks very solid. Please take a look at my 2 nits

Signed-off-by: Divam <dfordivam@gmail.com>

- Add MintingDelegationCollectRewardsTrigger - Bump version of DbExternalPartyWalletStore - Bump version of DbUserWalletStore Squashed commits from the PR reviewed in #3470 Signed-off-by: Divam <dfordivam@gmail.com>

Squashed commits from PR reviewed in #3598 Signed-off-by: Divam <dfordivam@gmail.com>

Extracted duplicated listSortedRewardCoupons method from DbUserWalletStore and DbExternalPartyWalletStore into a new shared mixin trait. PR reviewed in #3646 Signed-off-by: Divam <dfordivam@gmail.com>

Signed-off-by: Divam <dfordivam@gmail.com>

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Signed-off-by: Divam <dfordivam@gmail.com>

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Signed-off-by: Divam <dfordivam@gmail.com>

meiersi-da

Thank you @dfordivam and @adetokunbo for the very quick and thorough turnaround. This is good to go 💪 👏

PR reviewed on #3601 Signed-off-by: Tim Emiola <adetokunbo@emio.la>

dfordivam · 2026-01-23T08:59:12Z

Closing this commits have been squashed and merged on dfordivam/feature-cip-73-minting-delegation

dfordivam marked this pull request as ready for review January 21, 2026 07:16

dfordivam requested a review from meiersi-da January 21, 2026 07:19

dfordivam force-pushed the dfordivam/feature-cip-73-minting-delegation branch from 34f262a to 98c805c Compare January 22, 2026 05:24

dfordivam force-pushed the dfordivam/adetokunbo/cip-73-minting-delegations-ui branch from 2ce99c4 to 057af83 Compare January 22, 2026 06:00

meiersi-da reviewed Jan 22, 2026

View reviewed changes

ray-roestenburg-da requested a review from pawelperek-da January 22, 2026 15:42

pawelperek-da reviewed Jan 22, 2026

View reviewed changes

dfordivam and others added 18 commits January 23, 2026 04:35

Daml: Add MintingDelegation

9cbb28d

Signed-off-by: Divam <dfordivam@gmail.com>

Add MintingDelegation automation, APIs, and HTTP handler

d98d2c9

- Add MintingDelegationCollectRewardsTrigger - Bump version of DbExternalPartyWalletStore - Bump version of DbUserWalletStore Squashed commits from the PR reviewed in #3470 Signed-off-by: Divam <dfordivam@gmail.com>

DevelopmentFundCoupon minting in MintingDelegation

45cd83e

Squashed commits from PR reviewed in #3598 Signed-off-by: Divam <dfordivam@gmail.com>

Move listSortedRewardCoupons to common code DbTransferInputQueries

eff24a6

Extracted duplicated listSortedRewardCoupons method from DbUserWalletStore and DbExternalPartyWalletStore into a new shared mixin trait. PR reviewed in #3646 Signed-off-by: Divam <dfordivam@gmail.com>

[ci]

f919249

Signed-off-by: Divam <dfordivam@gmail.com>

Begin the delegations pane with a table of delegations

b23d843

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Add the table showing the proposals

935f495

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Wire the various buttons to the corresponding actions

47705ee

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Shorten the benificiaryId

636742e

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Show beneficiary onboarding status

8748069

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Add confirmation dialogs for the Accept/Withdraw/Reject buttons

f6b08ce

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Sort the delegations and proposal tables

05aa3d3

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Show popup when approving a Proposal matching a Delegation

e8fc449

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Verify delegations/proposals using WalletFrontendIntegrationTest

37e1892

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Update formatting

2e83449

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Confirm that proposal and delegations from non-onboard users are seen

6df3da6

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Use a non-validator user in the UI integration test

0e0c5ab

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

More reformatting

14041f1

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

dfordivam and others added 8 commits January 23, 2026 04:41

[ci]

9236d62

Signed-off-by: Divam <dfordivam@gmail.com>

Update table and column headings

e45e4ae

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Extract shortenPartyId into a util module

77d18b9

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Remove MintingDelegationProposalWithOnboardedStatus

41b233c

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Replace Onboarded column with a warning icon

cd62b37

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Use 'hosted' rather than 'onboarded' in non-generated code

8bd9723

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Rename beneficiaryOnboard to beneficiaryHosted in api and backend

8990113

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

Show popup when approving a Proposal matching a Delegation

8bcd148

Signed-off-by: Tim Emiola <adetokunbo@emio.la>

dfordivam force-pushed the dfordivam/feature-cip-73-minting-delegation branch from 98c805c to f919249 Compare January 23, 2026 04:43

[ci]

9bcf04f

Signed-off-by: Divam <dfordivam@gmail.com>

dfordivam force-pushed the dfordivam/adetokunbo/cip-73-minting-delegations-ui branch from 057af83 to 9bcf04f Compare January 23, 2026 04:46

meiersi-da approved these changes Jan 23, 2026

View reviewed changes

dfordivam pushed a commit that referenced this pull request Jan 23, 2026

Wallet UI support for minting delegations management

fd2600b

PR reviewed on #3601 Signed-off-by: Tim Emiola <adetokunbo@emio.la>

dfordivam force-pushed the dfordivam/feature-cip-73-minting-delegation branch from f919249 to 1da591d Compare January 23, 2026 08:57

dfordivam closed this Jan 23, 2026

	beneficiaryOnboarded: d.beneficiary_onboarded,
	beneficiaryHosted: d.beneficiary_hosted,

	<TableCell>Max Amulets</TableCell>
	<TableCell>Merge Threshold</TableCell>

Wallet UI support for minting delegations management #3601

Wallet UI support for minting delegations management #3601

Conversation

dfordivam commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Cluster Testing

PR Guidelines

Merge Guidelines

Uh oh!

adetokunbo commented Jan 21, 2026

1. Some delegation proposals are pending approval

2. One of them is approved

3. View of the confirmation dialog as the next one is being approved

4. After the second is approved

Uh oh!

adetokunbo commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

5. View of confirmation dialog as one of the approved delegations is withdrawn

6. After the delegation is withdrawn

7. View of confirmation dialog as the remaining proposal is rejected

8. After that proposal is rejected

Uh oh!

adetokunbo commented Jan 21, 2026

9. A new proposal and delegation appear from users that have not completed onboarding

10. A proposal appears from a user that updates their active delegation

11. View of the confirmation dialog when accepting the updating proposal

12. After the update is accepted

Uh oh!

meiersi-da left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adetokunbo Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adetokunbo Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawelperek-da left a comment

Choose a reason for hiding this comment

Uh oh!

meiersi-da left a comment

Choose a reason for hiding this comment

Uh oh!

dfordivam commented Jan 20, 2026 •

edited

Loading

adetokunbo commented Jan 21, 2026 •

edited

Loading

adetokunbo Jan 23, 2026 •

edited

Loading

adetokunbo Jan 23, 2026 •

edited

Loading