Skip to content

Conversation

@nicu-da
Copy link
Contributor

@nicu-da nicu-da commented Jan 20, 2026

[ci]

fixes #3521

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

[ci]

Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt I suggest also putting it in the relesae notes, did you check what guarantees this gives around crashes? Do you lose logs just before you crash?

@nicu-da
Copy link
Contributor Author

nicu-da commented Jan 20, 2026

lgmt I suggest also putting it in the relesae notes, did you check what guarantees this gives around crashes? Do you lose logs just before you crash?

If you have a crash without proper shutdown logs are indeed lost that are not yet written. But during shutdown we handle closing the logger #3521 (comment)

@moritzkiefer-da
Copy link
Contributor

sounds good thx

[ci]

Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
@nicu-da nicu-da enabled auto-merge (squash) January 20, 2026 12:49
@nicu-da nicu-da merged commit 11c8a44 into main Jan 20, 2026
62 checks passed
@nicu-da nicu-da deleted the nicuda/techdebt/log_async branch January 20, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swap default for async logging

3 participants