[ci] Add storeDescriptorUserVersion config to scan. #3615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rautenrieth-da
left a comment
rautenrieth-da
left a comment
There was a problem hiding this comment.
Needs a unit test and docs, but otherwise the change looks good.
What do you think of adding the same config to the validator and sv apps? Shouldn't be too much extra work and we would have options to reset those stores when we'll need it in the future.
| txLogBackfillBatchSize: Int = 100, | ||
| bftSequencers: Seq[BftSequencerConfig] = Seq.empty, | ||
| cache: ScanCacheConfig = ScanCacheConfig(), | ||
| storeDescriptorUserVersion: Option[Long] = None, |
Contributor
There was a problem hiding this comment.
I would let users configure the userVersion of acsStoreDescriptor and txLogStoreDescriptor independently. Otherwise it's impossible to bump one store without the other, and they are independent stores.
Contributor
Author
There was a problem hiding this comment.
right that makes sense
Contributor
Author
There was a problem hiding this comment.
I'll also add the config to the sv and validator apps, makes sense
ray-roestenburg-da
force-pushed
the
ray/scan-re-ingest-config/3534
branch
from
a14a29f to
eaab724
Compare
Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
…v app Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
Signed-off-by: Raymond Roestenburg <raymond.roestenburg@digitalasset.com>
ray-roestenburg-da
force-pushed
the
ray/scan-re-ingest-config/3534
branch
from
eaab724 to
044b9e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3615
(I think this is what @rautenrieth-da meant)
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines